OpenAFS CVS Commit: openafs/src/viced by shadow

Fri, 24 May 2002 18:05:48 EDT

Update of /cvs/openafs/src/viced
In directory GRAND.CENTRAL.ORG:/data/sb/openafs/src/viced

Modified Files:
Log Message:
DELTA viced-malloc-dont-make-assumptions-about-the-compiler-20020524

based on report from
"identP = (struct Identity *)malloc(1);

This can't be right, there should not be an assumption how the
c-compiler will lay out code. I find it acceptable to do something like this

	   /* sizeof valid + offset of valid. */
	   i.. = malloc(sizeof(identP->valid) + (int)&(((struct Identity *)0)->valid));

But then, why not just allocate a whole identP and be happy. A afsUUID
is not that bloted (16 bytes) so I can't see why way this is
chosen. 20 bytes will probably be allocated on 32 bit platforms for
the whole struct Identity.


--- DELTA config follows ---
viced-malloc-dont-make-assumptions-about-the-compiler-20020524 openafs/src/viced/host.c 1.15 1.16