OpenAFS Master Repository branch, openafs-stable-1_4_x, updated. abdf72bc87ec942b1d6ec8f84a4d3ea18c1205a9
Gerrit Code Review
Mon, 2 Nov 2009 04:42:55 -0800 (PST)
The following commit has been merged in the openafs-stable-1_4_x branch:
Author: Marc Dionne <firstname.lastname@example.org>
Date: Sun Nov 1 16:03:17 2009 -0500
Linux: Avoid deadlock in readdir - release GLOCK for filldir
The GLOCK is held while calling the filldir function in afs_linux_readdir().
If this function causes a page fault, and in particular if this fault
involves AFS, we're in trouble as we'll eventually deadlock in the
A simple test case for this is to call the getdents syscall on an
AFS directory with a buffer that is part of an mmaped AFS file.
This is already the case in the master branch; the change was part of
the merge of the NFS translator code.
Tested-by: Marc Dionne <email@example.com>
Reviewed-by: Simon Wilkinson <firstname.lastname@example.org>
Reviewed-by: Derrick Brashear <email@example.com>
src/afs/LINUX/osi_vnodeops.c | 2 ++
1 files changed, 2 insertions(+), 0 deletions(-)
OpenAFS Master Repository