OpenAFS Master Repository branch, master, updated. openafs-devel-1_5_66-23-g5a537f0
Gerrit Code Review
gerrit@openafs.org
Mon, 2 Nov 2009 04:43:26 -0800 (PST)
The following commit has been merged in the master branch:
commit 5a537f071970c38881fde1ad8508775fafd7489d
Author: Marc Dionne <marc.c.dionne@gmail.com>
Date: Sat Oct 31 08:54:52 2009 -0400
Fix memory allocation warnings at shutdown
At shutdown we check for unfreed memory allocated with AllocSmallSpace
and AllocLargeSpace and complain in the syslog if there are dangling
pieces. This patch takes care of a few cases that always showed up
as warnings, even after a simple start-stop of the client.
- The cacheInode file needs to be closed before the checks, since it
uses a large piece for its struct file.
- The ICL logging code allocates 6 small pieces that are never freed.
Add a shutdown_icl() function that releases everything. While we're
at it, correct one place where we allocated with afs_osi_Alloc but
freed with osi_FreeSmallSpace, confusing our accounting.
Change-Id: I4c28c848f155dec9d89e6199cde34209227ca5c9
Reviewed-on: http://gerrit.openafs.org/758
Reviewed-by: Simon Wilkinson <sxw@inf.ed.ac.uk>
Reviewed-by: Derrick Brashear <shadow@dementia.org>
Tested-by: Derrick Brashear <shadow@dementia.org>
src/afs/afs_call.c | 20 ++++++++++++++------
src/afs/afs_icl.c | 30 +++++++++++++++++++++++++++++-
src/afs/afs_prototypes.h | 1 +
3 files changed, 44 insertions(+), 7 deletions(-)
--
OpenAFS Master Repository