OpenAFS Master Repository branch, openafs-stable-1_4_x, updated. b7198421a222a06cf5f34c53e516c31f5edf587c
Gerrit Code Review
Thu, 5 Nov 2009 08:02:25 -0800 (PST)
The following commit has been merged in the openafs-stable-1_4_x branch:
Author: Marc Dionne <firstname.lastname@example.org>
Date: Sat Oct 31 08:54:52 2009 -0400
Fix memory allocation warnings at shutdown
At shutdown we check for unfreed memory allocated with AllocSmallSpace
and AllocLargeSpace and complain in the syslog if there are dangling
pieces. This patch takes care of a few cases that always showed up
as warnings, even after a simple start-stop of the client.
- The cacheInode file needs to be closed before the checks, since it
uses a large piece for its struct file.
- The ICL logging code allocates 6 small pieces that are never freed.
Add a shutdown_icl() function that releases everything. While we're
at it, correct one place where we allocated with afs_osi_Alloc but
freed with osi_FreeSmallSpace, confusing our accounting.
Reviewed-by: Simon Wilkinson <email@example.com>
Reviewed-by: Derrick Brashear <firstname.lastname@example.org>
Tested-by: Derrick Brashear <email@example.com>
src/afs/afs_call.c | 50 +++++++++++++++++++++++++++++++++++++++------
src/afs/afs_prototypes.h | 1 +
2 files changed, 44 insertions(+), 7 deletions(-)
OpenAFS Master Repository