OpenAFS Master Repository branch, master, updated. openafs-devel-1_5_65-130-gbbcfbe1
Gerrit Code Review
gerrit@openafs.org
Fri, 23 Oct 2009 13:03:20 -0700 (PDT)
The following commit has been merged in the master branch:
commit bbcfbe1a04eda9e75b1643be88cf9d4842a8aa86
Author: Andrew Deason <adeason@sinenomine.net>
Date: Thu Oct 22 11:12:30 2009 -0500
Avoid prematurely destroying callback_rxcon
Currently, h_GetHost_r and removeAddress_r can destroy the
callback_rxcon of a host. Having a NULL callback_rxcon can cause
segfaults in code that does not properly check if a host has been
HOSTDELETED before trying to use it.
Although such code is incorrect and should be fixed, we can still avoid
a segfault in those situations by not destroying callback_rxcon until we
destroy the host itself. This just prevents destroying callback_rxcon in
h_GetHost_r and removeAddress_r, leaving it to h_TossStuff_r to destroy
when it destroys the host.
Change-Id: I6fd5cbb924053446689c576026f9044f78ba71be
Reviewed-on: http://gerrit.openafs.org/717
Tested-by: Andrew Deason <adeason@sinenomine.net>
Reviewed-by: Jeffrey Altman <jaltman@openafs.org>
Tested-by: Derrick Brashear <shadow@dementia.org>
Reviewed-by: Derrick Brashear <shadow@dementia.org>
src/viced/host.c | 40 +++++++++++-----------------------------
1 files changed, 11 insertions(+), 29 deletions(-)
--
OpenAFS Master Repository