OpenAFS Master Repository branch, master, updated. openafs-devel-1_5_75-127-g89afd3c
Gerrit Code Review
gerrit@openafs.org
Mon, 2 Aug 2010 09:27:38 -0700 (PDT)
The following commit has been merged in the master branch:
commit 89afd3c21e816c29f497c10cf76673d009cdd919
Author: Jeffrey Altman <jaltman@your-file-system.com>
Date: Sat Jul 31 00:21:06 2010 -0400
Windows: Do not reference cm_data.rootSCachep directly
cm_data.rootSCachep is a global pointer to the cm_scache_t that
represents the root.afs volume root directory. Throughout the
code this cm_scache_t was being used without ensuring that a
callback to the volume is in fact valid.
Under most circumstances this would not be a problem. However,
it is possible for a request to fail due to the lack of a callback
at a critical moment. Add a new function cm_rootScachep() that
attempts to ensure that a callback is present (if possible) prior
to use the cm_scache_t object.
LICENSE MIT
Change-Id: I997dc05a2214788d32727c261947206a61cd8d32
Reviewed-on: http://gerrit.openafs.org/2491
Reviewed-by: Jeffrey Altman <jaltman@openafs.org>
Tested-by: Jeffrey Altman <jaltman@openafs.org>
src/WINNT/afsd/cm_freelance.c | 4 +-
src/WINNT/afsd/cm_scache.c | 16 ++++++++++++++
src/WINNT/afsd/cm_scache.h | 2 +
src/WINNT/afsd/cm_vnodeops.c | 12 +++++-----
src/WINNT/afsd/cm_volstat.c | 6 ++--
src/WINNT/afsd/rpc_srvsvc.c | 8 +++++-
src/WINNT/afsd/smb.c | 44 ++++++++++++++++++++++------------------
src/WINNT/afsd/smb3.c | 42 ++++++++++++++++++++------------------
src/WINNT/afsd/smb_ioctl.c | 12 +++++-----
9 files changed, 87 insertions(+), 59 deletions(-)
--
OpenAFS Master Repository