OpenAFS Master Repository branch, master, updated. openafs-devel-1_5_75-128-g5e946d5
Gerrit Code Review
gerrit@openafs.org
Mon, 2 Aug 2010 09:35:49 -0700 (PDT)
The following commit has been merged in the master branch:
commit 5e946d5b6672d4dea7dd1c3ee669245b3d2ced92
Author: Andrew Deason <adeason@sinenomine.net>
Date: Fri Jul 30 15:32:53 2010 -0500
ptserver: Do not use cell for entry name len check
Do not use the local cell name when determining if a new entry name is
too long. This check assumes that foreign cells will use our local
cell name (assumed to be our local Kerberos realm) in a certain way,
and prevents creating users that will make those names too long.
This is undesirable for several reasons. One is that the local realm
name may not be the same as the local cell name (and we may have many
local realms). Another is that we cannot reliably predict how foreign
cells will construct foreign pt entry names, so preventing entry
creation based on that may prevent names that will never cause any
problems. This check also assumes that our names will be used as
foreign entries in other cells, which may not be the case.
So, remove the check based on the local cell name, and remove the
pr_realmNameLen variable while we are at it, since this is all it is
used for.
Thanks to Jeffrey Altman for discussion, and for bringing this up in
the first place.
Change-Id: Ief4bc94d9ead61a1589797b5dc663a6473c9ed72
Reviewed-on: http://gerrit.openafs.org/2488
Tested-by: Derrick Brashear <shadow@dementia.org>
Reviewed-by: Derrick Brashear <shadow@dementia.org>
src/ptserver/ptserver.c | 2 --
src/ptserver/ptutils.c | 24 ++++++------------------
src/ptserver/ubik.c | 1 -
3 files changed, 6 insertions(+), 21 deletions(-)
--
OpenAFS Master Repository