OpenAFS Master Repository branch, master, updated. openafs-devel-1_5_68-100-gc5d9f23

Gerrit Code Review gerrit@openafs.org
Fri, 15 Jan 2010 18:02:41 -0800 (PST)


The following commit has been merged in the master branch:
commit c5d9f23cde1a024835582536e56cf4ea1652b7a8
Author: Jeffrey Altman <jaltman@your-file-system.com>
Date:   Fri Jan 15 09:18:50 2010 -0500

    Rx: Do not drop call lock in rx_WriteProc* and rx_ReadProc*
    
    rx_WriteProc and rx_ReadProc has special fast logic that
    handles the most frequent case.  This code was called
    without obtaining the call lock. However, each of these functions
    must obtain the call lock for the queue_IsNotEmpty() test and
    must re-obtain the call lock if the rxi_XXX variant is required.
    Dropping the lock and re-obtaining it is more expensive than
    holding it across the memcpy.  Therefore, we shouldn't drop the
    lock until we are done.
    
    Change-Id: Icca679567994e91bbbf3afec72b863d986f86582
    Reviewed-on: http://gerrit.openafs.org/1108
    Reviewed-by: Derrick Brashear <shadow@dementia.org>
    Tested-by: Jeffrey Altman <jaltman@openafs.org>
    Reviewed-by: Simon Wilkinson <sxw@inf.ed.ac.uk>
    Tested-by: Simon Wilkinson <sxw@inf.ed.ac.uk>
    Reviewed-by: Jeffrey Altman <jaltman@openafs.org>

 src/rx/rx_rdwr.c |   60 ++++++++++-------------------------------------------
 1 files changed, 12 insertions(+), 48 deletions(-)

-- 
OpenAFS Master Repository