OpenAFS Master Repository branch, master, updated. openafs-devel-1_5_68-101-gdf70221

Gerrit Code Review gerrit@openafs.org
Fri, 15 Jan 2010 18:06:04 -0800 (PST)


The following commit has been merged in the master branch:
commit df702210275453e0d2362b0e142d82bfaf14406c
Author: Jeffrey Altman <jaltman@your-file-system.com>
Date:   Fri Jan 15 09:06:05 2010 -0500

    Rx: Correct AFS_NT40_ENV rx_GetIFInfo max MTU assignments
    
    On UNIX, the rx library values for rx_maxReceiveSize and
    rx_MyMaxSendSize are sent by the cache manager directly.
    In Windows, they are set by rx_GetIFInfo() which had two
    errors.
    
    (1) The comparison of rx_maxReceiveSize and maxsize were
        reversed which prevented rx_maxReceiveSize from ever
        being set to the interface MTU.
    
    (2) rx_MyMaxSendSize was never assigned a value.
    
    As a result, two problems occurred.
    
    (1) The remote peer was never told about the local MTU.
    
    (2) The local peer ignores the MTU.
    
    From 1.3.60 to 1.5.33, OpenAFS for Windows installers
    provided a registry default RxMaxMTU of 1260.  This caused
    the cache manager to call rx_SetMaxMTU() which in turn set
    both rx_maxReceiveSize and rx_MyMaxSendSize in effect
    masking these errors.
    
    Change-Id: Ib05927d7985052e233ff6f4bd170a939eb05c320
    Reviewed-on: http://gerrit.openafs.org/1107
    Reviewed-by: Jeffrey Altman <jaltman@openafs.org>
    Tested-by: Jeffrey Altman <jaltman@openafs.org>

 src/rx/rx_user.c |    6 ++++--
 1 files changed, 4 insertions(+), 2 deletions(-)

-- 
OpenAFS Master Repository