OpenAFS Master Repository branch, openafs-stable-1_6_x, updated. openafs-stable-1_6_0b-85-g465e613

Gerrit Code Review
Wed, 26 Oct 2011 15:56:33 -0700 (PDT)

The following commit has been merged in the openafs-stable-1_6_x branch:
commit 465e613b5d73380374eb69a226f4227e976e1f5c
Author: Andrew Deason <>
Date:   Mon Aug 29 17:41:31 2011 -0500

    Currently VRequestSalvage_r takes a flag,
    VOL_SALVAGE_INVALIDATE_HEADER, which causes the header for the
    specified volume to be freed (via FreeVolumeHeader). This is almost
    never safe to do, since there may be other users of the specified
    volume that can be accessing the volume header at the same time.
    There is also no reason to invalidate the header at the time of the
    VRequestSalvage_r call, since the header must be invalidated when we
    detach the volume (other utilities may change header information). So,
    if there are any problems in the future because we do not invalidate
    the header at the time of VRequestSalvage_r, it is the fault of the
    detachment/offlining logic.
    So, remove VOL_SALVAGE_INVALIDATE_HEADER and all of its users. Take
    this opportunity to correctly document the VRequestSalvage_r headers
    in the VRequestSalvage_r comment, as it was previously missing the
    Reviewed-by: Derrick Brashear <>
    Tested-by: BuildBot <>
    (cherry picked from commit 4552dc552687267fce3c7a6a9c7f4a1e9395c8e5)
    Change-Id: Ib991ecefea2115a3c4308ed3c261af7433c9b858
    Reviewed-by: Derrick Brashear <>
    Tested-by: Derrick Brashear <>

 src/vol/volume.c |   39 ++++++++++++---------------------------
 src/vol/volume.h |    3 +--
 2 files changed, 13 insertions(+), 29 deletions(-)

OpenAFS Master Repository