OpenAFS Master Repository branch, master, updated. BP--openafs-stable-1_6_x-1617-gca0f194
Gerrit Code Review
gerrit@openafs.org
Tue, 6 Sep 2011 17:43:14 -0700 (PDT)
The following commit has been merged in the master branch:
commit ca0f1946a2f0a75be7de6aa0ac083ffebc950624
Author: Simon Wilkinson <sxw@your-file-system.com>
Date: Tue Jul 5 09:27:05 2011 +0100
volser: Don't declare cstruct twice
Both vsprocs.c and vsutils.c declare the global variable 'cstruct'
(which is initialised by vos.c in order to pass a ubik client structure
through to many of the libvolser functions). This double declaration
prevents libvolser from being linked as a shared library on some
platforms. We only need one of these, so just make vsprocs.c declare it,
and vsutils.c refer to it as an extern.
Of course, using a global variable to pass state around is really quite
nasty, but let's fix that in another change.
Change-Id: Ief1667bd7a5b70dbfb49cdc02cc435eb2344527e
Reviewed-on: http://gerrit.openafs.org/5362
Tested-by: BuildBot <buildbot@rampaginggeek.com>
Reviewed-by: Derrick Brashear <shadow@dementix.org>
Reviewed-by: Jeffrey Altman <jaltman@openafs.org>
Tested-by: Jeffrey Altman <jaltman@openafs.org>
src/volser/vsprocs.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
--
OpenAFS Master Repository