OpenAFS Master Repository branch, master, updated. BP--openafs-stable-1_6_x-1618-g3277620
Gerrit Code Review
gerrit@openafs.org
Tue, 6 Sep 2011 17:44:41 -0700 (PDT)
The following commit has been merged in the master branch:
commit 327762071be3806c5d08be0218982c7027754756
Author: Simon Wilkinson <sxw@your-file-system.com>
Date: Tue Jul 5 09:20:15 2011 +0100
rx/rxkad: Move rxkad initialisation into rxkad
When the RX pthread conversion was done, the initialisation of rxkad
mutexes was incorporated into the rx library itself. This is a layering
violation (it breaks the relatively clean security object abstraction),
and means that you can't actually use RX without the rxkad library.
So, remove all of this initialisation from RX. As security libraries
don't have an explicit initialisation function, we setup our various
mutexes using a pthread_once function called from the NewSecurityObject
functions.
This has the added bonus that it removes the final error in rx.c for
pthread builds, and so another bit of warning suppression can be
removed.
Change-Id: I3cf9b2404a03fb58534c5f41afd77aa5ba5e2256
Reviewed-on: http://gerrit.openafs.org/5361
Reviewed-by: Derrick Brashear <shadow@dementix.org>
Tested-by: Jeffrey Altman <jaltman@openafs.org>
Reviewed-by: Jeffrey Altman <jaltman@openafs.org>
README.WARNINGS | 1 -
src/libafsrpc/Makefile.in | 1 -
src/rx/rx.c | 6 ------
src/rxkad/rxkad_client.c | 7 ++++---
src/rxkad/rxkad_common.c | 38 ++++++++++++++++++++++++++++++++------
src/rxkad/rxkad_prototypes.h | 4 ++--
src/rxkad/rxkad_server.c | 2 ++
src/rxkad/stats.h | 1 -
src/shlibafsrpc/Makefile.in | 1 -
9 files changed, 40 insertions(+), 21 deletions(-)
--
OpenAFS Master Repository