OpenAFS Master Repository branch, master, updated. openafs-devel-1_5_76-3530-g41d9ea6
Gerrit Code Review
gerrit@openafs.org
Wed, 27 Feb 2013 12:41:22 -0800 (PST)
The following commit has been merged in the master branch:
commit 41d9ea697bf5e81e5003ad7b208788223c25536b
Author: Simon Wilkinson <sxw@your-file-system.com>
Date: Tue Feb 26 22:27:25 2013 +0000
auth: Fix buffer overflow in afsconf_Open
If we fallback to the .AFSCONF file in the user's homedirectory,
the results of getenv("HOME") are copied into a fixed length string,
without checking for overflows.
Instead of risking this, just use asprintf to dynamically construct
a string, and free it when we are done.
Caught by coverity (#985905)
Change-Id: Id8769ede841165d3ff3104143e55767d550d6f87
Reviewed-on: http://gerrit.openafs.org/9292
Tested-by: BuildBot <buildbot@rampaginggeek.com>
Reviewed-by: Derrick Brashear <shadow@your-file-system.com>
Reviewed-by: Jeffrey Altman <jaltman@your-file-system.com>
src/auth/cellconfig.c | 12 ++++++++++--
1 files changed, 10 insertions(+), 2 deletions(-)
--
OpenAFS Master Repository