OpenAFS Master Repository branch, master, updated. openafs-devel-1_5_76-3242-gf2f7ba5
Gerrit Code Review
gerrit@openafs.org
Wed, 2 Jan 2013 12:06:11 -0800 (PST)
The following commit has been merged in the master branch:
commit 7b642173c7cd7b6b7130214c1a940501736abbf0
Author: Andrew Deason <adeason@sinenomine.net>
Date: Fri Dec 28 12:58:33 2012 -0500
viced: Avoid dangling uuid hash table entry
Currently we add a given host to the uuid hash table, then call
RXAFS_InitCallBackState3, and then only initialize the host->interface
structure if the ICBS3 call succeeded.
If the ICBS3 call fails, we have added a host to the uuid hash table,
but the host structure does not contain that uuid. If the host is then
deleted, we will not remove the host from the uuid hash table (since
host->interface is NULL), and so the uuid hash table entry will still
point to the freed host. If that host is then later looked up via that
uuid, we can reference a freed host, which can cause all kinds of
undefined behavior.
So instead, add the host to the uuid hash table at the same time that
we initialize the host->interface structure, inside
initInterfaceAddr_r.
FIXES 131277
Change-Id: Ib2ca82cc498877ec896ab1806cf675f1271ec214
Reviewed-on: http://gerrit.openafs.org/8846
Reviewed-by: Derrick Brashear <shadow@your-file-system.com>
Tested-by: BuildBot <buildbot@rampaginggeek.com>
src/viced/host.c | 3 ++-
1 files changed, 2 insertions(+), 1 deletions(-)
--
OpenAFS Master Repository