OpenAFS Master Repository branch, master, updated. openafs-devel-1_5_76-3242-gf2f7ba5
Gerrit Code Review
gerrit@openafs.org
Wed, 2 Jan 2013 12:06:11 -0800 (PST)
The following commit has been merged in the master branch:
commit f2f7ba50ed61a6187814d633327a8cacda0f656f
Author: Andrew Deason <adeason@sinenomine.net>
Date: Fri Dec 28 13:16:49 2012 -0500
viced: initInterfaceAddr_r regardless of ICBS code
Currently we only call initInterfaceAddr_r for a host if a call to
RXAFS_InitCallBackState3 succeeds. However, this leaves the host
without a host->interface structure, which indicates that the host
does not support UUIDs, and is represented by just a single host,port
pair.
But this is not correct; the host probably does have the relevant UUID
associated with it, but it is just not responding. So, with the
current code, we create a uuid-less host structure for a host that
probably has a uuid; that host structure will probably never be used,
and will just get deleted later.
So instead, always call initInterfaceAdd_r. Do it before the ICBS
call, so the host will be findable via UUID as early as possible. If
the ICBS call fails, the host will be marked as 'down' later on.
Change-Id: I3a000af90773acbdd66fc22718e5e742619839a1
Reviewed-on: http://gerrit.openafs.org/8847
Tested-by: BuildBot <buildbot@rampaginggeek.com>
Reviewed-by: Derrick Brashear <shadow@your-file-system.com>
src/viced/host.c | 5 +++--
1 files changed, 3 insertions(+), 2 deletions(-)
--
OpenAFS Master Repository