OpenAFS Master Repository branch, openafs-stable-1_6_x, updated. openafs-stable-1_6_6-27-g2667f59

Gerrit Code Review
Wed, 19 Feb 2014 05:04:37 -0800 (PST)

The following commit has been merged in the openafs-stable-1_6_x branch:
commit 2667f59e12ddba9d73c9996a28d7c63414887713
Author: Benjamin Kaduk <>
Date:   Wed Feb 5 18:32:16 2014 -0500

    afs_fetchstore: re-avoid uninitialized variable
    As noted in the gerrit comments for change 10742, commit
    baf6af8a8f2207ce39b746d59ca4bc661c002883 does not handle the case
    where the second rx_Read() call fails, and the 'length' variable
    can still be used uninitialized.
    Instead of using an err label and jumping to it on the case of
    errors, initialize length to zero and take care to neither
    set nor access *alength if an error has occurred.  This is
    more consistent with the style of the surrounding code while still
    avoiding the use of an uninitialized variable.
    Tested-by: BuildBot <>
    Reviewed-by: Jeffrey Altman <>
    (cherry picked from commit b7326e487f6387033282cc5d1128b00a0456673a)
    Change-Id: I371ec319b9a984e61e41a30110b8f2c0cf14b379
    Tested-by: BuildBot <>
    Reviewed-by: D Brashear <>
    Reviewed-by: Andrew Deason <>
    Reviewed-by: Stephan Wiesand <>

 src/afs/afs_fetchstore.c |   11 +++++------
 1 files changed, 5 insertions(+), 6 deletions(-)

OpenAFS Master Repository