OpenAFS Master Repository branch, openafs-stable-1_6_x, updated. openafs-stable-1_6_6-26-g596b464

Gerrit Code Review
Wed, 19 Feb 2014 05:04:05 -0800 (PST)

The following commit has been merged in the openafs-stable-1_6_x branch:
commit 596b464d20150bbb816176cb278e2e9c845edecd
Author: Benjamin Kaduk <>
Date:   Thu Jan 9 22:42:26 2014 -0500

    afs_fetchstore: avoid use of uninitialized variable
    rxfs_fetchInit() attempts to do a 64-bit RPC first, but falls back
    to the 32-bit StartRXAFS_FetchData() if the server appears to not
    support the 64-bit RPCs.
    We correctly did not read a length from the call if the FetchData
    RPC(s) failed, but proceeded to assign from the 'length' local
    variable into the 'alength' output variable unconditionally later on.
    Instead of blindly continuing on, jump to the error-handling part of
    the routine when we cannot read a length from the call.  This has the
    side effect of skipping an afs_Trace3() point in the error case.
    Reviewed-by: Derrick Brashear <>
    Tested-by: Benjamin Kaduk <>
    (cherry picked from commit baf6af8a8f2207ce39b746d59ca4bc661c002883)
    Change-Id: Icf14d5e8a6abf8a8a014ab7d48b767e3dcc7a6a9
    Tested-by: BuildBot <>
    Reviewed-by: D Brashear <>
    Reviewed-by: Andrew Deason <>
    Reviewed-by: Stephan Wiesand <>

 src/afs/afs_fetchstore.c |    5 ++++-
 1 files changed, 4 insertions(+), 1 deletions(-)

OpenAFS Master Repository