OpenAFS Master Repository branch, master, updated. BP-openafs-stable-1_8_x-631-gba8b924
Gerrit Code Review
gerrit@openafs.org
Thu, 2 Jul 2020 21:58:07 -0400
The following commit has been merged in the master branch:
commit ba8b92401b8cb2f5a5306313c2702cb36cba083c
Author: Andrew Deason <adeason@sinenomine.net>
Date: Sun Jul 8 15:00:02 2018 -0500
afs: Bound afs_DoBulkStat dir scan
Currently, afs_DoBulkStat will scan the entire directory blob, looking
for entries to stat. If all or almost all entries are already stat'd,
we'll scan through the entire directory, doing nontrivial work on
each entry (we grab afs_xvcache, at least). All of this work is pretty
pointless, since the entries are already cached and so we won't do
anything. If many processes are trying to acquire afs_xvcache, this
can contribute to performance issues.
To avoid this, provide a constant bound on the number of entries we'll
search through: nentries * 4. The current arbitrary limits cap
nentries at 30, so this means we're capping the afs_DoBulkStat search
to 120 entries.
Change-Id: I66e9af5b27844ddf6cf37c8286fcc65f8e0d3f96
Reviewed-on: https://gerrit.openafs.org/13253
Tested-by: BuildBot <buildbot@rampaginggeek.com>
Reviewed-by: Benjamin Kaduk <kaduk@mit.edu>
src/afs/VNOPS/afs_vnop_lookup.c | 16 ++++++++++++++--
1 files changed, 14 insertions(+), 2 deletions(-)
--
OpenAFS Master Repository