OpenAFS Master Repository branch, master, updated. BP-openafs-stable-1_8_x-636-gf9d20c6
Gerrit Code Review
Fri, 3 Jul 2020 18:19:05 -0400
The following commit has been merged in the master branch:
Author: Cheyenne Wills <firstname.lastname@example.org>
Date: Thu Jul 2 13:39:27 2020 -0600
LINUX: Don't panic on some file open errors
Commit 'LINUX: Return NULL for afs_linux_raw_open error' (f6af4a155)
updated afs_linux_raw_open to return NULL on some errors, but still
panics if obtaining the dentry fails.
Commit 'afs: Verify osi_UFSOpen worked' (c6b61a451) updated callers of
osi_UFSOpen to verify whether or not the open was successful. This
meant osi_UFSOpen (and routines it calls) could pass back an error
indication rather than panic when an error is encountered.
Update afs_linux_raw_open to return a failure instead of panic if unable
to obtain a dentry.
Update osi_UFSOpen to return a NULL instead of panic if unable to obtain
memory or fails to open the file. All callers of osi_UFSOpen handle a
fail return, though some will still issue a panic.
Update afs_linux_readpage_fastpath and afs_linux_readpages to not panic
if afs_linux_raw_open fails. Instead of panic, return an error.
For testing, an error can be forced by removing a file from the
Note this work is based on a commit by email@example.com
Reviewed-by: Andrew Deason <firstname.lastname@example.org>
Reviewed-by: Mark Vitale <email@example.com>
Reviewed-by: Benjamin Kaduk <firstname.lastname@example.org>
Tested-by: BuildBot <email@example.com>
src/afs/LINUX/osi_file.c | 15 +++++++++++----
src/afs/LINUX/osi_vnodeops.c | 17 +++++++++++++----
2 files changed, 24 insertions(+), 8 deletions(-)
OpenAFS Master Repository