OpenAFS Master Repository branch, master, updated. openafs-devel-1_9_0-23-ge8702e6
Gerrit Code Review
Sat, 24 Oct 2020 00:47:51 -0400
The following commit has been merged in the master branch:
Author: Mark Vitale <firstname.lastname@example.org>
Date: Fri Oct 28 18:12:19 2016 -0400
afs: prevent double release of global lock afs_xvcb
afs_GetServer calls ReleaseWriteLock(&afs_xvcb) twice within a few
lines. The second one is spurious.
Commits b18653de7ae90491c2e75f4a98410581655d776c 'xserver lock order
violation' and f2bf60ed4f1323cd6f74f2f01114f7e4f714db53 'xvcb lock order
violation' were written by the same author at the same time and
apparently were victims of a bad merge.
Discovered during a lock audit project as a panic during afsd startup:
assertion failed: (&afs_xvcb)->excl_locked == WRITE_LOCK, file:
/home/mvitale/src/sna-openafs/src/afs/afs_server.c, line: 2089
afs_GetServer is called frequently by many threads and so this bug could
easily have released another thread's write lock on afs_xvcb.
Remove the spurious second release.
Tested-by: BuildBot <email@example.com>
Reviewed-by: Benjamin Kaduk <firstname.lastname@example.org>
src/afs/afs_server.c | 2 --
1 files changed, 0 insertions(+), 2 deletions(-)
OpenAFS Master Repository