OpenAFS Master Repository branch, master, updated. openafs-devel-1_9_0-27-g3e3fce2

[Gerrit Code Review]

The following commit has been merged in the master branch:
commit 3e3fce24da31a31ca9a3f4ad356c4e4eaf0ad897
Author: Andrew Deason <adeason@sinenomine.net>
Date:   Mon Nov 12 15:01:18 2018 -0600

    vlserver: Warn when we cannot unhash deleted entry
    
    If we are trying to delete an entry from the vldb, we fail with
    VL_NOENT if we cannot find the given entry on one of its hash chains.
    This is indicative of corruption in the vldb (since we have an entry
    not on a hash chain), but we don't really indicate this clearly. There
    are no log messages, and the user running 'vos' only sees an error
    like this:
    
        $ vos delentry 123456
        Could not delete entry for volume 123456
        You must specify a RW volume name or ID (the entire VLDB entry will be deleted)
        VLDB: no such entry
        Deleted 0 VLDB entries
    
    Which is the exact same error message if the user tries to delete a
    volume that does not actually exist.
    
    We currently do not have an error code that clearly says that the
    database appears corrupted and needs to be fixed, but we can at least
    log an error in VLLog for this case, to give the administrator a
    chance at fixing the situation. So, log a message in this situation.
    
    Change-Id: I4f0ee8749a90441e1f8d779890293dc5d1d9dbee
    Reviewed-on: https://gerrit.openafs.org/13382
    Tested-by: BuildBot <buildbot@rampaginggeek.com>
    Reviewed-by: Benjamin Kaduk <kaduk@mit.edu>

 src/vlserver/vlutils.c |   19 +++++++++++++++++--
 1 files changed, 17 insertions(+), 2 deletions(-)

-- 
OpenAFS Master Repository