OpenAFS Master Repository branch, master, updated. openafs-devel-1_9_1-25-gb60754e

Gerrit Code Review
Thu, 10 Jun 2021 12:21:50 -0400

The following commit has been merged in the master branch:
commit b60754ed1c1f2d1593ffc35a5febf39a50404134
Author: Andrew Deason <>
Date:   Mon Jun 7 18:23:39 2021 -0500

    afs: Avoid creating unused conns
    In afs_LoopServers and PCallBackAddr, we loop over our known servers
    to issue an RPC, but we skip over servers on various conditions. For
    most of those, we skip over the server before creating the relevant
    conn (via afs_ConnBySA), but not for the
    SRVADDR_ISDOWN/afs_HaveCallBacksFrom check. If we skip over the server
    for that reason, we'll create an afs_conn and rx_connection, and then
    release our refs without using them.
    This doesn't cause any big problems, but it does create extra
    connections and peers that linger around for at least a couple of
    hours (until they get cleaned up by afs_GCUserData).
    It's very easy to avoid these extra useless conns; just perform the
    SRVADDR_ISDOWN/afs_HaveCallBacksFrom check before we call
    afs_ConnBYSA. This also makes the check a bit more consistent with the
    other checks we do.
    Change-Id: Ie49b87e5dd755f77364502528a02c14944e8c23d
    Tested-by: BuildBot <>
    Reviewed-by: Benjamin Kaduk <>

 src/afs/afs_pioctl.c |   20 ++++++++++++--------
 src/afs/afs_server.c |   27 +++++++++++++++------------
 2 files changed, 27 insertions(+), 20 deletions(-)

OpenAFS Master Repository