OpenAFS Master Repository branch, master, updated. openafs-devel-1_9_1-84-g02c3d56
Gerrit Code Review
gerrit@openafs.org
Sun, 5 Sep 2021 12:16:21 -0400
The following commit has been merged in the master branch:
commit 02c3d56956dc4c94a9076b6d7eb56d26534faa9c
Author: Andrew Deason <adeason@dson.org>
Date: Mon Apr 27 13:28:33 2020 -0500
afs: Avoid touching CBRs after free
Currently, we free our CBR structures in shutdown_vcache, but later on
in shutdown_server, we call afs_FreeCBR on each one that's attached to
a struct server. afs_FreeCBR doesn't actually free the memory; it just
modifies some pointers to put the CBR on the free list. Since we do
this after the underlying memory has been freed, it can cause a panic
during shutdown since the structures are no longer valid.
To avoid this, make the afs_FreeCBR calls inside shutdown_vcache,
right before the memory is freed.
Change-Id: I142126d6aa811762b6c234d05abdac3764dad887
Reviewed-on: https://gerrit.openafs.org/14165
Reviewed-by: Michael Meffie <mmeffie@sinenomine.net>
Reviewed-by: Benjamin Kaduk <kaduk@mit.edu>
Tested-by: BuildBot <buildbot@rampaginggeek.com>
src/afs/afs_init.c | 8 --------
src/afs/afs_vcache.c | 17 +++++++++++++++++
2 files changed, 17 insertions(+), 8 deletions(-)
--
OpenAFS Master Repository