OpenAFS Master Repository branch, master, updated. openafs-devel-1_9_1-85-g7924aec

Gerrit Code Review gerrit@openafs.org
Mon, 6 Sep 2021 19:23:18 -0400


The following commit has been merged in the master branch:
commit 7924aecf95bf4918a485a041f2426bd1fa407ac8
Author: Michael Meffie <mmeffie@sinenomine.net>
Date:   Fri Sep 3 07:05:36 2021 -0400

    ptserver: Fix CreateEntry() stringop-overflow warnings
    
    The CreateEntry() prototype has been fixed to match the function
    definition, so callers are expected to provide bounded arrays for the
    user or group name. Fix the InitialGroup() macro which is used to set
    the built-in names using string literal to avoid stringop-overflow
    warnings.
    
        error: ‘CreateEntry’ accessing 64 bytes in a region of size 22 [-Werror=stringop-overflow=]
                code = CreateEntry(tt, (name), &temp, /*idflag*/1, flag, SYSADMINID, SYSADMINID); \
    
        note: in expansion of macro ‘InitialGroup’
               InitialGroup(SYSADMINID, "system:administrators");
        note: referencing argument 2 of type ‘char *’
        note: in a call to function ‘CreateEntry’
                CreateEntry(struct ubik_trans *at, char aname[PR_MAXNAMELEN], ...
    
        (Repeated for "system:backup", "system:anyuser", "system:authuser",
        "system:ptsviewers", and "anonymous".)
    
    Change-Id: I7a37d4c8e191ffff52c2fdc1ed3783f4c3592b11
    Reviewed-on: https://gerrit.openafs.org/14789
    Reviewed-by: Benjamin Kaduk <kaduk@mit.edu>
    Tested-by: Benjamin Kaduk <kaduk@mit.edu>

 src/ptserver/ptutils.c | 9 ++++++++-
 1 file changed, 8 insertions(+), 1 deletion(-)

-- 
OpenAFS Master Repository