OpenAFS Master Repository branch, openafs-stable-1_8_x, updated. openafs-stable-1_8_8_1-46-g07704dc
Gerrit Code Review
gerrit@openafs.org
Thu, 4 Aug 2022 13:01:03 -0400
The following commit has been merged in the openafs-stable-1_8_x branch:
commit 07704dc7b4a58a05e921d374302a3026fa95a44e
Author: Michael Meffie <mmeffie@sinenomine.net>
Date: Mon Aug 23 15:42:52 2021 -0400
libadmin: Fix isAlias may be uninitialized warning
The cfgutil_HostNameIsAlias() function has an output parameter called
isAlias, which is used when cfgutil_HostIsAlias() returns non-zero.
However, it possible for isAlias to not be set before returning. GCC 12
issues a warning about the possible use of the uninitialized isAlias
variable:
cfginternal.c:366:32: error: ‘isAlias’ may be used uninitialized
[-Werror=maybe-uninitialized]
Initialize the cfgutil_HostNameIsAlias() isAlias output flag to false.
Also, fix the misleading code indentation around the
cfgutil_HostNameIsAlias() call.
Reviewed-on: https://gerrit.openafs.org/14772
Reviewed-by: Cheyenne Wills <cwills@sinenomine.net>
Tested-by: BuildBot <buildbot@rampaginggeek.com>
Reviewed-by: Benjamin Kaduk <kaduk@mit.edu>
(cherry picked from commit 4a8d0c4089078fb3df9cc06b595c80c9b4c2ca7f)
Change-Id: I4cadcb4380962e47213fcfd310c1cac331100f65
Reviewed-on: https://gerrit.openafs.org/14986
Reviewed-by: Michael Meffie <mmeffie@sinenomine.net>
Reviewed-by: Mark Vitale <mvitale@sinenomine.net>
Tested-by: BuildBot <buildbot@rampaginggeek.com>
Reviewed-by: Andrew Deason <adeason@sinenomine.net>
Reviewed-by: Marcio Brito Barbosa <mbarbosa@sinenomine.net>
Reviewed-by: Stephan Wiesand <stephan.wiesand@desy.de>
src/libadmin/cfg/cfginternal.c | 20 ++++++++++----------
1 file changed, 10 insertions(+), 10 deletions(-)
--
OpenAFS Master Repository