OpenAFS Master Repository branch, openafs-stable-1_8_x, updated. openafs-stable-1_8_8_1-47-g0cb26f1

Gerrit Code Review gerrit@openafs.org
Thu, 4 Aug 2022 13:02:05 -0400


The following commit has been merged in the openafs-stable-1_8_x branch:
commit 0cb26f198c6e049171b698098afab82203848434
Author: Michael Meffie <mmeffie@sinenomine.net>
Date:   Fri Sep 3 07:05:36 2021 -0400

    ptserver: Fix CreateEntry() stringop-overflow warnings
    
    The CreateEntry() prototype has been fixed to match the function
    definition, so callers are expected to provide bounded arrays for the
    user or group name. Fix the InitialGroup() macro which is used to set
    the built-in names using string literal to avoid stringop-overflow
    warnings.
    
        error: ‘CreateEntry’ accessing 64 bytes in a region of size 22 [-Werror=stringop-overflow=]
                code = CreateEntry(tt, (name), &temp, /*idflag*/1, flag, SYSADMINID, SYSADMINID); \
    
        note: in expansion of macro ‘InitialGroup’
               InitialGroup(SYSADMINID, "system:administrators");
        note: referencing argument 2 of type ‘char *’
        note: in a call to function ‘CreateEntry’
                CreateEntry(struct ubik_trans *at, char aname[PR_MAXNAMELEN], ...
    
        (Repeated for "system:backup", "system:anyuser", "system:authuser",
        "system:ptsviewers", and "anonymous".)
    
    Reviewed-on: https://gerrit.openafs.org/14789
    Reviewed-by: Benjamin Kaduk <kaduk@mit.edu>
    Tested-by: Benjamin Kaduk <kaduk@mit.edu>
    (cherry picked from commit 7924aecf95bf4918a485a041f2426bd1fa407ac8)
    
    Change-Id: I6e30729f1b24beb1ed1c4b6d9162b347285b7edc
    Reviewed-on: https://gerrit.openafs.org/14987
    Reviewed-by: Michael Meffie <mmeffie@sinenomine.net>
    Reviewed-by: Mark Vitale <mvitale@sinenomine.net>
    Tested-by: BuildBot <buildbot@rampaginggeek.com>
    Reviewed-by: Andrew Deason <adeason@sinenomine.net>
    Reviewed-by: Marcio Brito Barbosa <mbarbosa@sinenomine.net>
    Reviewed-by: Stephan Wiesand <stephan.wiesand@desy.de>

 src/ptserver/ptutils.c | 9 ++++++++-
 1 file changed, 8 insertions(+), 1 deletion(-)

-- 
OpenAFS Master Repository