OpenAFS Master Repository branch, openafs-stable-1_8_x, updated. openafs-stable-1_8_8_1-54-gb34c14d
Gerrit Code Review
gerrit@openafs.org
Thu, 4 Aug 2022 13:31:54 -0400
The following commit has been merged in the openafs-stable-1_8_x branch:
commit b34c14dae1ed94bc24580278e90b57df2b92b496
Author: Cheyenne Wills <cwills@sinenomine.net>
Date: Thu Jul 2 13:39:27 2020 -0600
LINUX: Don't panic on some file open errors
Commit 'LINUX: Return NULL for afs_linux_raw_open error' (f6af4a155)
updated afs_linux_raw_open to return NULL on some errors, but still
panics if obtaining the dentry fails.
Commit 'afs: Verify osi_UFSOpen worked' (c6b61a451) updated callers of
osi_UFSOpen to verify whether or not the open was successful. This
meant osi_UFSOpen (and routines it calls) could pass back an error
indication rather than panic when an error is encountered.
Update afs_linux_raw_open to return a failure instead of panic if unable
to obtain a dentry.
Update osi_UFSOpen to return a NULL instead of panic if unable to obtain
memory or fails to open the file. All callers of osi_UFSOpen handle a
fail return, though some will still issue a panic.
Update afs_linux_readpage_fastpath and afs_linux_readpages to not panic
if afs_linux_raw_open fails. Instead of panic, return an error.
For testing, an error can be forced by removing a file from the
cache directory.
Note this work is based on a commit by pruiter@sinenomine.net
Reviewed-on: https://gerrit.openafs.org/14242
Reviewed-by: Andrew Deason <adeason@sinenomine.net>
Reviewed-by: Mark Vitale <mvitale@sinenomine.net>
Reviewed-by: Benjamin Kaduk <kaduk@mit.edu>
Tested-by: BuildBot <buildbot@rampaginggeek.com>
(cherry picked from commit af73b9a3b1fc625694807287c0897391feaad52d)
Change-Id: I1e430403561d5b85d6a4094d4bf413a6eca4ff5a
Reviewed-on: https://gerrit.openafs.org/15052
Tested-by: BuildBot <buildbot@rampaginggeek.com>
Reviewed-by: Michael Laß <lass@mail.uni-paderborn.de>
Reviewed-by: Michael Meffie <mmeffie@sinenomine.net>
Reviewed-by: Stephan Wiesand <stephan.wiesand@desy.de>
src/afs/LINUX/osi_file.c | 15 +++++++++++----
src/afs/LINUX/osi_vnodeops.c | 17 +++++++++++++----
2 files changed, 24 insertions(+), 8 deletions(-)
--
OpenAFS Master Repository