OpenAFS Master Repository branch, openafs-stable-1_8_x, updated. openafs-stable-1_8_8_1-56-ge03825b

Gerrit Code Review gerrit@openafs.org
Thu, 4 Aug 2022 13:34:55 -0400


The following commit has been merged in the openafs-stable-1_8_x branch:
commit e03825bf22c615d7fec18481dc0145b79a3b3e82
Author: Cheyenne Wills <cwills@sinenomine.net>
Date:   Fri Jan 28 14:10:46 2022 -0700

    Linux-5.17: Kernel build uses -Wcast-function-type
    
    The linux 5.17 commit:
      "Makefile: Enable -Wcast-function-type" (552a23a0)
    added the -Wcast-function-type compiler flag for kernel module builds.
    
    This change catches a type mismatch in the external files obtained from
    heimdal: hcrypto/evp.c and hcrypto/evp-algs.c and produces the following
    type of compile time error messages.
    
      src/libafs/MODLOAD-.../evp.c: In function ‘hc_EVP_md_null’:
      src/libafs/MODLOAD-.../evp.c:501:2: error: cast between incompatible
          function types from ‘void (*)(void *)’ to ‘int (*)(EVP_MD_CTX *)’
              {aka ‘int (*)(struct hc_EVP_MD_CTX *)’}
              [-Werror=cast-function-type]
      501 |  (hc_evp_md_init)null_Init,
          |  ^
    
    Use AX_APPEND_COMPILE_FLAGS to create a CFLAGS_NOCAST_FUNCTION_TYPE
    macro to disable this warning and update the CFLAGS for these 2 files
    for the Linux libafs build.
    
    Update the CODING documentation to add the new exceptions.  In addition
    add a brief description on how to set up autoconf to add a new build
    macro to suppress compiler warnings.
    
    Note: upstream heimdal has committed a fix for this in:
    
       hcrypto: Fix return type for null_Init, null_Update and null_Final
       (fc4b3ce49b)
    
    Reviewed-on: https://gerrit.openafs.org/14881
    Reviewed-by: Benjamin Kaduk <kaduk@mit.edu>
    Tested-by: BuildBot <buildbot@rampaginggeek.com>
    Reviewed-by: Andrew Deason <adeason@sinenomine.net>
    (cherry picked from commit 6bdfa976731ce07f3236893ecf12abb9e169b882)
    
    Change-Id: Ibd354f663d5876c421a8b4e89b8943c9e3d59ebc
    Reviewed-on: https://gerrit.openafs.org/14946
    Reviewed-by: Michael Meffie <mmeffie@sinenomine.net>
    Reviewed-by: Mark Vitale <mvitale@sinenomine.net>
    Tested-by: BuildBot <buildbot@rampaginggeek.com>
    Reviewed-by: Andrew Deason <adeason@sinenomine.net>
    Reviewed-by: Stephan Wiesand <stephan.wiesand@desy.de>

 CODING                            | 12 +++++++++++-
 src/cf/osconf.m4                  |  4 ++++
 src/libafs/MakefileProto.LINUX.in |  5 +++--
 3 files changed, 18 insertions(+), 3 deletions(-)

-- 
OpenAFS Master Repository