OpenAFS Master Repository branch, master, updated. openafs-devel-1_9_1-435-g20e996a
Gerrit Code Review
gerrit@openafs.org
Mon, 8 Jul 2024 14:52:27 -0400
The following commit has been merged in the master branch:
commit 20e996af4e065a2d7801fcccdc52f15cd40543c1
Author: Andrew Deason <adeason@sinenomine.net>
Date: Thu Jul 4 12:31:06 2024 -0500
cf: Prevent default CFLAGS in OPENAFS_PATH_CC
Commit dba6ec9548ab (cf: Set CC before calling AC_PROG_CC) moved our
logic for preventing a default CFLAGS from the top-level
configure.ac/configure-libafs.ac into OPENAFS_CONFIGURE_COMMON. This
doesn't work, because OPENAFS_CONFIGURE_COMMON calls
AC_USE_SYSTEM_EXTENSIONS, which effectively runs the compiler and sets
default CFLAGS at the beginning of OPENAFS_CONFIGURE_COMMON.
This means that if the user doesn't specify any CFLAGS, autoconf will
set our CFLAGS to the default of '-g -O2', which can break various
environments. (For example, --disable-optimize no longer works, because
that flag only controls the OPTMZ var, and doesn't touch CFLAGS.)
To fix this, move our logic for preventing default CFLAGS into
OPENAFS_PATH_CC, which is explicitly called before
OPENAFS_CONFIGURE_COMMON so we can set the compiler before autoconf sets
its defaults. This should ensure that we are setting CFLAGS before
autoconf does; otherwise, we're also probably not setting CC early
enough, either.
Change-Id: Ic64e46aee35ffd3b5ee4ad1241c4c7366d9ccb67
Reviewed-on: https://gerrit.openafs.org/15778
Tested-by: BuildBot <buildbot@rampaginggeek.com>
Reviewed-by: Cheyenne Wills <cwills@sinenomine.net>
Reviewed-by: Michael Meffie <mmeffie@sinenomine.net>
acinclude.m4 | 2 --
src/cf/cc.m4 | 3 +++
2 files changed, 3 insertions(+), 2 deletions(-)
--
OpenAFS Master Repository