OpenAFS Master Repository branch, master, updated. openafs-devel-1_9_1-513-gad7a5ba

Gerrit Code Review gerrit@openafs.org
Thu, 26 Sep 2024 10:21:56 -0400


The following commit has been merged in the master branch:
commit ad7a5ba33399f47c781cb5b177bab1e578eaca23
Author: Andrew Deason <adeason@sinenomine.net>
Date:   Tue Oct 25 16:37:41 2022 -0500

    FBSD: Cast afs_symlink target to char*
    
    FreeBSD commit 1493c2ee62b8cbd8dbe70670b9108b4b9c36e032 (Make
    vop_symlink take a const target path.) changed the 'target' argument
    of vop_symlink to be a 'const char*' (from 'char*'). This causes a
    warning:
    
        .../src/afs/FBSD/osi_vnodeops.c:1099:44: error: passing 'const char *' to parameter of type 'char *' discards qualifiers [-Werror,-Wincompatible-pointer-types-discards-qualifiers]
                afs_symlink(VTOAFS(dvp), name, ap->a_vap, ap->a_target, NULL,
                                                          ^~~~~~~~~~~~
        .../src/afs/afs_prototypes.h:1328:37: note: passing argument to parameter 'atargetName' here
                               struct vattr *attrs, char *atargetName,
    
    Just cast to 'char*' explicitly to get rid of the warning.
    
    Ideally we would change afs_symlink() to accept a 'const char*', but
    that involves a lot of changes to cross-platform code; keep things
    simple for now.
    
    Change-Id: Iaa2d18a3168827c45908d44328f90425c9d1cb12
    Reviewed-on: https://gerrit.openafs.org/15171
    Reviewed-by: Michael Meffie <mmeffie@sinenomine.net>
    Tested-by: BuildBot <buildbot@rampaginggeek.com>
    Reviewed-by: Andrew Deason <adeason@sinenomine.net>

 src/afs/FBSD/osi_vnodeops.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

-- 
OpenAFS Master Repository