OpenAFS Master Repository branch, openafs-stable-1_8_x, updated. openafs-stable-1_8_12_1-1-g9e64b7d
Gerrit Code Review
gerrit@openafs.org
Thu, 26 Sep 2024 12:26:37 -0400
The following commit has been merged in the openafs-stable-1_8_x branch:
commit 9e64b7d068f42e02980442e8e65114577176df19
Author: Mark Vitale <mvitale@sinenomine.net>
Date: Fri May 7 18:20:11 2021 -0400
rx: Define symbolic names for Rx magic numbers
Since the original IBM code import, the magic number '6' has been used
to specify the number of consecutive lost keepalives (ping acks) that
indicate a dead connection. By implication, this also defines the
minimum number of seconds (at the minimum keeplive periodicity of 1
second) before a connection may be considered dead.
Define and use symbolic names for both uses of '6', and document their
relationship. Both have the same assigned value '6', but
RX_PINGS_LOST_BEFORE_DEAD is use as an ordinal count, while
RX_MINDEADTIME is expressed in units of seconds.
The magic number '12' is used in a couple of places for the default
value of rx_connDeadTime. Give this constant a name
(RX_DEFAULT_DEAD_TIME) and use it.
No functional change is incurred by this commit.
Reviewed-on: https://gerrit.openafs.org/14621
Reviewed-by: Benjamin Kaduk <kaduk@mit.edu>
Tested-by: Benjamin Kaduk <kaduk@mit.edu>
(cherry picked from commit b4a4a2ae9c9546482dd94c7a89793b1bfa1714cd)
Change-Id: I87c2de0c1a14a9414a86e6fc0744139a120fbab9
Reviewed-on: https://gerrit.openafs.org/15852
Reviewed-by: Michael Meffie <mmeffie@sinenomine.net>
Tested-by: BuildBot <buildbot@rampaginggeek.com>
Reviewed-by: Andrew Deason <adeason@sinenomine.net>
Reviewed-by: Mark Vitale <mvitale@sinenomine.net>
Reviewed-by: Cheyenne Wills <cwills@sinenomine.net>
Reviewed-by: Benjamin Kaduk <kaduk@mit.edu>
src/rx/rx.c | 12 ++++++------
src/rx/rx.h | 12 ++++++++++++
src/rx/rx_globals.h | 2 +-
3 files changed, 19 insertions(+), 7 deletions(-)
--
OpenAFS Master Repository