OpenAFS Master Repository branch, master, updated. openafs-devel-1_9_2-289-g2ed8262
Gerrit Code Review
gerrit@openafs.org
Tue, 5 Aug 2025 14:30:18 -0400
The following commit has been merged in the master branch:
commit 2ed826203cb9442d3cf44bf43e455a18f34960e4
Author: Andrew Deason <adeason@sinenomine.net>
Date: Thu Jul 31 16:11:45 2025 -0500
DARWIN: Clarify privhelper.c 'code' clobbering
Add some comments in privhelper.c to clarify that we are deliberately
overwriting the value of 'code' in non-command-failure error paths. This
does cause us to lose some error info when returning this to our XPC
caller, but actually recording what went wrong is done via syslog()
calls; our callers tend to not care what the specific error is, so more
sophisticated error reporting over XPC isn't really needed.
Change-Id: I4532a7a37217031aa4f7c8208dee2c5f7cb6b930
Reviewed-on: https://gerrit.openafs.org/16493
Tested-by: BuildBot <buildbot@rampaginggeek.com>
Reviewed-by: Benjamin Kaduk <kaduk@mit.edu>
Reviewed-by: Cheyenne Wills <cwills@sinenomine.net>
Reviewed-by: Gaurav Saxena <gsaxena@sinenomine.net>
Reviewed-by: Michael Meffie <mmeffie@sinenomine.net>
src/platform/DARWIN/PrivilegedHelper/privhelper.c.in | 9 ++++++++-
1 file changed, 8 insertions(+), 1 deletion(-)
--
OpenAFS Master Repository