OpenAFS Master Repository branch, openafs-stable-1_8_x, updated. openafs-stable-1_8_13_2-106-g58ae311

Gerrit Code Review gerrit@openafs.org
Wed, 6 Aug 2025 15:15:54 -0400


The following commit has been merged in the openafs-stable-1_8_x branch:
commit 58ae3117f0f691ffe621c1f219813193975a6742
Author: GANESH CHAUDHARI <gangovind@in.ibm.com>
Date:   Wed Jan 15 15:54:03 2025 -0500

    DARWIN: Cast arguments to afs_syscall_pioctl()
    
    In recent versions of Xcode (around the release of macOS 14), mismatched
    argument types are now flagged as errors instead of warnings:
    
        src/afs/afs_syscall.c:659:22: error: incompatible integer to pointer
                                      conversion passing 'afs_int32' (aka 'int') to
                                      parameter of type 'char *' [-Wint-conversion]
    
          afs_syscall_pioctl(uap->parm1, uap->parm2, uap->parm3,
                             ^~~~~~~~~~
    
        src/afs/afs_syscall.c:659:46: error: incompatible integer to pointer
                                      conversion passing 'afs_int32' (aka 'int') to
                                      parameter of type 'caddr_t' (aka 'char *')
                                      [-Wint-conversion]
    
          afs_syscall_pioctl(uap->parm1, uap->parm2, uap->parm3,
                                                     ^~~~~~~~~~
    
    Add approriate casts to parameters 1 and 3.
    
    [mvitale: commit message details]
    
    Reviewed-on: https://gerrit.openafs.org/16141
    Reviewed-by: Marcio Brito Barbosa <mbarbosa@sinenomine.net>
    Reviewed-by: Mark Vitale <mvitale@sinenomine.net>
    Reviewed-by: Michael Meffie <mmeffie@sinenomine.net>
    Reviewed-by: Andrew Deason <adeason@sinenomine.net>
    Tested-by: Andrew Deason <adeason@sinenomine.net>
    (cherry picked from commit 0eb223a36de2f80e11d81fafba10ded6912d3327)
    
    Change-Id: Ic77003be33fb73ea49d844b95ebd5318eb3e2908
    Reviewed-on: https://gerrit.openafs.org/16184
    Reviewed-by: Michael Meffie <mmeffie@sinenomine.net>
    Reviewed-by: Andrew Deason <adeason@sinenomine.net>
    Reviewed-by: Mark Vitale <mvitale@sinenomine.net>
    Tested-by: BuildBot <buildbot@rampaginggeek.com>
    Reviewed-by: Benjamin Kaduk <kaduk@mit.edu>

 src/afs/afs_syscall.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

-- 
OpenAFS Master Repository