OpenAFS Master Repository branch, master, updated. openafs-devel-1_9_2-81-gb8ab76cc
Gerrit Code Review
gerrit@openafs.org
Tue, 21 Jan 2025 10:45:54 -0500
The following commit has been merged in the master branch:
commit b8ab76cca297d7ccbf15defd3f6a391c8a786db0
Author: Cheyenne Wills <cwills@sinenomine.net>
Date: Wed Jan 15 13:40:23 2025 -0700
cf: Invoke AC_PROG_RANLIB with AC_REQUIRE
With libtool 2.5.3, the libtool commit:
"libtoolize: Fix conflicting warnings about AC_PROG_RANLIB" (3e6c628)
added an AC_REQUIRE([AC_PROG_RANLIB]), which resulted in the following
messages when running ./regen.sh
Running autoconf
configure.ac:16: warning: AC_REQUIRE: 'AC_PROG_RANLIB' was expanded before it was required
configure.ac:16: https://www.gnu.org/software/autoconf/manual/autoconf.html#Expanded-Before-Required
src/cf/libtool.m4:1577: _LT_CMD_OLD_ARCHIVE is expanded from...
src/cf/libtool.m4:153: _LT_SETUP is expanded from...
src/cf/libtool.m4:62: LT_INIT is expanded from...
src/cf/afs-libtool.m4:18: AFS_LT_INIT is expanded from...
src/cf/osconf.m4:2: OPENAFS_OSCONF is expanded from...
acinclude.m4:7: OPENAFS_CONFIGURE_COMMON is expanded from...
configure.ac:16: the top level
Running autoconf for configure-libafs
configure-libafs.ac:12: warning: AC_REQUIRE: 'AC_PROG_RANLIB' was expanded before it was required
configure-libafs.ac:12: https://www.gnu.org/software/autoconf/manual/autoconf.html#Expanded-Before-Required
src/cf/libtool.m4:1577: _LT_CMD_OLD_ARCHIVE is expanded from...
src/cf/libtool.m4:153: _LT_SETUP is expanded from...
src/cf/libtool.m4:62: LT_INIT is expanded from...
src/cf/afs-libtool.m4:18: AFS_LT_INIT is expanded from...
src/cf/osconf.m4:2: OPENAFS_OSCONF is expanded from...
acinclude.m4:7: OPENAFS_CONFIGURE_COMMON is expanded from...
configure-libafs.ac:12: the top level
According to the autoconf documentation for AC_REQUIRE, if we expand a
macro using AC_REQUIRE, we're always supposed to expand the macro using
AC_REQUIRE, and never expand it normally. With libtool 2.5.3, LT_INIT
expands AC_PROG_RANLIB via AC_REQUIRE, and so we must also use
AC_REQUIRE for our AC_PROG_RANLIB calls. So, change all of our
AC_PROG_RANLIB calls to use AC_REQUIRE.
We currently call AC_PROG_RANLIB in both OPENAFS_CONFIGURE_COMMON and
OPENAFS_OSCONF (called from OPENAFS_CONFIGURE_COMMON). We don't interact
with RANLIB outside of OPENAFS_OSCONF, so just get rid of the duplicate
AC_PROG_RANLIB call in OPENAFS_CONFIGURE_COMMON instead of converting it
to AC_REQUIRE.
Change-Id: Iff7e29cef3e9ef019c6781c081fa5ca007356ac2
Reviewed-on: https://gerrit.openafs.org/16090
Reviewed-by: Andrew Deason <adeason@sinenomine.net>
Reviewed-by: Cheyenne Wills <cwills@sinenomine.net>
Tested-by: BuildBot <buildbot@rampaginggeek.com>
Reviewed-by: Michael Meffie <mmeffie@sinenomine.net>
Reviewed-by: Mark Vitale <mvitale@sinenomine.net>
Tested-by: Mark Vitale <mvitale@sinenomine.net>
acinclude.m4 | 1 -
src/cf/osconf.m4 | 2 +-
2 files changed, 1 insertion(+), 2 deletions(-)
--
OpenAFS Master Repository