OpenAFS Master Repository branch, master, updated. openafs-devel-1_9_2-82-g5b5fc11
Gerrit Code Review
gerrit@openafs.org
Tue, 21 Jan 2025 10:47:44 -0500
The following commit has been merged in the master branch:
commit 5b5fc11ed5a616e25b330dfaa0802c4dea842918
Author: Cheyenne Wills <cwills@sinenomine.net>
Date: Thu Jul 1 15:14:55 2021 -0600
budb: Fix problems found by static analysis
Several static analysis tools have identified various problems:
- file left open from early exit (infer)
- missing checks to ensure *alloc was successful (infer)
- possible memory leaks (scan-build, cppcheck)
To resolve the above problems:
- close file before exiting
- add checks to ensure *alloc was successful before using the memory
- fix possible memory leaks by freeing memory
This commit is a reorganization of commits developed by Pat Riehecky,
who ran the static analysis tools and developed the fixes.
Change-Id: I63873549c1cfef7aadffc0b3167ef33e067c7b69
Reviewed-on: https://gerrit.openafs.org/14678
Tested-by: BuildBot <buildbot@rampaginggeek.com>
Reviewed-by: Cheyenne Wills <cwills@sinenomine.net>
Reviewed-by: Michael Meffie <mmeffie@sinenomine.net>
Reviewed-by: Marcio Brito Barbosa <mbarbosa@sinenomine.net>
Reviewed-by: Andrew Deason <adeason@sinenomine.net>
src/budb/db_hash.c | 4 ++++
src/budb/procs.c | 4 +++-
src/budb/server.c | 8 ++------
3 files changed, 9 insertions(+), 7 deletions(-)
--
OpenAFS Master Repository