OpenAFS Master Repository branch, master, updated. openafs-devel-1_9_2-414-gf812601

Gerrit Code Review gerrit@openafs.org
Thu, 15 Jan 2026 11:31:50 -0500


The following commit has been merged in the master branch:
commit 906872eaa073754668013ae2cd27ff030f99a449
Author: Andrew Deason <adeason@sinenomine.net>
Date:   Tue Jan 13 20:44:02 2026 -0600

    config: Remove $target on cc-wrapper error
    
    Currently, we use the cc-wrapper script to run ctfconvert and ctfmerge
    after compiling/linking a target (usually on Solaris; those programs are
    rare on other platforms). But if the relevant ctfconvert command (or
    anything else) in the cc-wrapper script fails, the target file will
    still exist after cc-wrapper exits.
    
    This can create confusing situations: if ctfconvert fails when running
    'make', and then the user runs 'make' again, 'make' will see that the
    target already exists, and won't run cc-wrapper to compile the relevant
    file again. So the build will continue effectively without running
    ctfconvert on that one file.
    
    To try to avoid this, delete the target file if we encounter any errors
    in cc-wrapper, after we've determined what the target file is. This way,
    if we encounter an error after compiling/linking the relevant file, the
    file will be removed and so subsequent 'make' runs will try to build it
    again.
    
    Change-Id: I7ca14c0264ad08c774725ebf426d5c7ebff6a3c0
    Reviewed-on: https://gerrit.openafs.org/16674
    Reviewed-by: Michael Meffie <mmeffie@sinenomine.net>
    Reviewed-by: Cheyenne Wills <cwills@sinenomine.net>
    Reviewed-by: Mark Vitale <mvitale@sinenomine.net>
    Tested-by: BuildBot <buildbot@rampaginggeek.com>
    Reviewed-by: Marcio Brito Barbosa <mbarbosa@sinenomine.net>
    Reviewed-by: Andrew Deason <adeason@sinenomine.net>

 src/config/cc-wrapper.in | 9 +++++++++
 1 file changed, 9 insertions(+)

-- 
OpenAFS Master Repository