[OpenAFS-devel] strings.h or strings.h

[Derrick J Brashear]

> what was broken on aix?  we have a couple aches and pains boxes here that
> i could the following patch against. 
(following patch, which just changed ordering, but did not include both, 
removed; the question then is what does that break, and the answer is i
should line up all my test systems and find out, but that wasn't the
original question, which was what if both are included? including both, in
the other order, works fine on AIX, btw)

src/util/volparse.c breaks when set up this way:
#ifdef HAVE_STRING_H
#include <string.h>
#endif
#ifdef HAVE_STRINGS_H
#include <strings.h>
#endif

thusly (for obvious reasons if you e.g. grep rindex /usr/include/string*):

"/usr/include/strings.h", line 52.20: 1506-010 (W) Macro index invoked
with a null argument for parameter __s1.
"/usr/include/strings.h", line 52.20: 1506-041 (E) The invocation of macro
index contains fewer arguments than required by the macro definition.
"/usr/include/strings.h", line 52.14: 1506-275 (S) Unexpected text ','
encountered.
"/usr/include/strings.h", line 53.21: 1506-010 (W) Macro rindex invoked
with a null argument for parameter __s1.
"/usr/include/strings.h", line 53.21: 1506-041 (E) The invocation of macro
rindex contains fewer arguments than required by the macro definition.
"/usr/include/strings.h", line 53.14: 1506-275 (S) Unexpected text ','
encountered.