[OpenAFS-devel] More symbol problems for Red Hat 7.1 SMP (patches included)

Derek Atkins warlord@MIT.EDU
14 Aug 2001 14:25:15 -0400


Hi,

I've been working with people at cert (thanks Rudolph and Quinn) to
get OpenAFS to build properly on a RH 7.1 system.  I've finally tracked
down the problem.  The problem, it appears, is two fold:

	1) Not every file was changed so afsconfig.h was included
           before afs/param.h

	2) rpcgen needed to be modified to include afsconfig.h in the
           kernel includes.

The included patches fix all of these problems.  Having applied these
patches, I was able to build modules for both SP and MP systems at the
same time on RH 7.1, and both sets of modules work.

-derek

Changes:
	src/rx/rx.c: move afsconfig.h
	src/rx/rx_event.c: move afsconfig.h
	src/rxgen/rpc_main.c: add afsconfig.h to generated files


Index: src/rx/rx.c
===================================================================
RCS file: /cvs/openafs/src/rx/rx.c,v
retrieving revision 1.18
diff -u -r1.18 rx.c
--- src/rx/rx.c	2001/07/05 15:20:44	1.18
+++ src/rx/rx.c	2001/08/14 12:45:29
@@ -9,12 +9,12 @@
 
 /* RX:  Extended Remote Procedure Call */
 
+#include <afsconfig.h>
 #ifdef	KERNEL
 #include "../afs/param.h"
 #else
 #include <afs/param.h>
 #endif
-#include <afsconfig.h>
 
 RCSID("$Header: /cvs/openafs/src/rx/rx.c,v 1.18 2001/07/05 15:20:44 shadow Exp $");
 
Index: src/rx/rx_event.c
===================================================================
RCS file: /cvs/openafs/src/rx/rx_event.c,v
retrieving revision 1.5
diff -u -r1.5 rx_event.c
--- src/rx/rx_event.c	2001/07/05 15:20:44	1.5
+++ src/rx/rx_event.c	2001/08/14 13:49:22
@@ -7,12 +7,12 @@
  * directory or online at http://www.openafs.org/dl/license10.html
  */
 
+#include <afsconfig.h>
 #ifdef	KERNEL
 #include "../afs/param.h"
 #else
 #include <afs/param.h>
 #endif
-#include <afsconfig.h>
 
 RCSID("$Header: /cvs/openafs/src/rx/rx_event.c,v 1.5 2001/07/05 15:20:44 shadow Exp $");
 
Index: src/rxgen/rpc_main.c
===================================================================
RCS file: /cvs/openafs/src/rxgen/rpc_main.c,v
retrieving revision 1.9
diff -u -r1.9 rpc_main.c
--- src/rxgen/rpc_main.c	2001/07/12 19:59:10	1.9
+++ src/rxgen/rpc_main.c	2001/08/14 14:45:33
@@ -531,6 +531,7 @@
 	f_print(fout, "#define	_RXGEN_%s_\n\n", uppercase(fullname));
 	f_print(fout, "#ifdef	KERNEL\n");
 	f_print(fout, "/* The following 'ifndefs' are not a good solution to the vendor's omission of surrounding all system includes with 'ifndef's since it requires that this file is included after the system includes...*/\n");
+	f_print(fout, "#include <afsconfig.h>\n");
 	f_print(fout, "#include \"../afs/param.h\"\n");
 	f_print(fout, "#ifdef	UKERNEL\n");
 	f_print(fout, "#include \"../afs/sysincludes.h\"\n");

-- 
       Derek Atkins, SB '93 MIT EE, SM '95 MIT Media Laboratory
       Member, MIT Student Information Processing Board  (SIPB)
       URL: http://web.mit.edu/warlord/    PP-ASEL-IA     N1NWH
       warlord@MIT.EDU                        PGP key available