[OpenAFS-devel] afs_dentry_iput patch (linux)

Chas Williams chas@cmf.nrl.navy.mil
Wed, 24 Jan 2001 15:06:46 -0500


>Ok. While I admit I like the fact that you are deleting code that generates
>an error message on some of my clients (web and other servers) - I wonder if
>that is a good approach or if it will just hide my problem. :)

well... it will just move the error actually.  i am looking at this same
bug.  i only see it on SMP systems.  i believe xxx_iput() needs to 
atleast a spin_lock.  looking at osi_iput (a 2.4 specific version)
it seems to me that osi_iput could be called again on the same inode between
the entry and afs_delete_inode.

i basically see 'Bad refCount 0...' which makes me thing that
afs_delete_inode() doesnt get finished before iput() is called again.
at one point, i put lock_kernel()/unlock_kernel() afs_delete_inode
but i suspect it needs to be a higher up.

not gospel, just some thoughts.