[OpenAFS-devel] bug building against RedHat 7.3 new kernel: 2.4.18-5

[Tim C.]

> >> Looks like some of RH's patching went wrong, or they applied a broken
> >> patch. I would revert to -4.
>
>    It doesn't actually look like a broken patch; the problem is that the
> 2.4.18-5 version of include/linux/sched.h has a block of code that looks
> like:
>
> #if CONFIG_SMP
> ...
> #endif
>
> rather than using
>
> #ifdef CONFIG_SMP
>
  I actually wouldn't patch openafs for this.  The kernel should not be doing a
#if CONFIG_SMP.  It should be doing a #ifdef.  If you look, everywhere else in
the code does that.  Looks like someone just fixed that file too fast or
something.
  So I'd say install the kernel-source, change that one line in
/usr/src/linux-2.4/include/linux/sched.h, and then openafs should build.

Tim

> and we #define CONFIG_SMP to an empty value in
> src/config/param.i386_linux24.h (actually in all of the param headers
> for all of the linux ports).   Applying the patch below lets me build
> successfully for 2.4.18-5.
>
> --- param.i386_linux24.h        2002/01/31 21:48:23     1.1.1.1
> +++ param.i386_linux24.h        2002/06/21 06:10:49
> @@ -30,7 +30,7 @@
>   * MP to compile for Linux
>   */
>  #ifdef AFS_SMP
> -#define CONFIG_SMP
> +#define CONFIG_SMP 1
>  #ifndef CONFIG_X86_LOCAL_APIC
>  #define CONFIG_X86_LOCAL_APIC
>  #endif
>
> --
> Russ Allbery (rra@stanford.edu)             <http://www.eyrie.org/~eagle/>
> _______________________________________________
> OpenAFS-devel mailing list
> OpenAFS-devel@openafs.org
> https://lists.openafs.org/mailman/listinfo/openafs-devel
>

-----------------------------------------------------------------------
Tim Craig		These are my opinions and not my employers. :)
OIT-Systems	&	Imaging Research Center
tim@umbc.edu		It's hard to be serious when you're
			naked. - Garfield
-----------------------------------------------------------------------