[OpenAFS-devel] problem with aix 5.1 patch that was applied...

[Neulinger, Nathan]

How should this be dealt with? It looks to me that the
afs_osi_Wakeup/Sleep routines are all type void, and are not returning
anything, yet code changes applied in afs_dcache.c and rx.c assume it
returns an int.=20

-- Nathan

------------------------------------------------------------
Nathan Neulinger                       EMail:  nneul@umr.edu
University of Missouri - Rolla         Phone: (573) 341-4841
Computing Services                       Fax: (573) 341-4216


> -----Original Message-----
> From: Neulinger, Nathan=20
> Sent: Monday, September 30, 2002 8:20 AM
> To: openafs-devel@openafs.org
> Subject: [OpenAFS-devel] problem with aix 5.1 patch that was=20
> applied...
>=20
>=20
>=20
> There are probably others - these afs_osi_Wakeup calls in the if's are
> not valid. It returns a void when compiling the kernel.=20
>=20
> Module won't build on i386_linux24 at the moment.=20
>=20
> ../afs/afs_dcache.c:2002: warning: passing arg 1 of `DZap' from
> incompatible pointer type
> ../afs/afs_dcache.c:2024: void value not ignored as it ought to be
> ../afs/afs_dcache.c:2335: void value not ignored as it ought to be
> ../afs/afs_dcache.c:2353: warning: passing arg 1 of `DZap' from
> incompatible pointer type
>=20
> -- Nathan
>=20
>=20
> @@ -2011,7 +2021,12 @@
>         tdc->validPos =3D Position;       /*  which is
> AFS_CHUNKBASE(abyte) */
>         if (tdc->mflags & DFFetchReq) {
>             tdc->mflags &=3D ~DFFetchReq;
> -           afs_osi_Wakeup(&tdc->validPos);
> +           if (afs_osi_Wakeup(&tdc->validPos) =3D=3D 0)
> +               afs_Trace4(afs_iclSetp, CM_TRACE_DCACHEWAKE,
> +                      ICL_TYPE_STRING, __FILE__,
> +                      ICL_TYPE_INT32, __LINE__,
> +                      ICL_TYPE_POINTER, tdc,
> +                      ICL_TYPE_INT32, tdc->dflags);
>         }
>         tsmall =3D (struct tlocal1 *) =
osi_AllocLargeSpace(sizeof(struct
> tlocal1));
>         setVcacheStatus =3D 0;
> @@ -2108,8 +2123,6 @@
>                     } else {
>                         bytes =3D rx_Read(tcall, (char *)&length_hi,
> sizeof(afs_int32));
>                         RX_AFS_GLOCK();
> -                       afs_Trace2(afs_iclSetp, CM_TRACE_FETCH64CODE,
> -                                  ICL_TYPE_POINTER, avc,
> ICL_TYPE_INT32, code);
>                         if (bytes =3D=3D sizeof(afs_int32)) {
>                             length_hi =3D ntohl(length_hi);
>                         } else {
> @@ -2319,12 +2332,12 @@
>  #endif /* AFS_NOSTATS */
> =20
>         tdc->dflags &=3D ~DFFetching;
> -       afs_Trace4(afs_iclSetp, CM_TRACE_DCACHEWAKE,
> -                  ICL_TYPE_STRING, __FILE__,
> -                  ICL_TYPE_INT32, __LINE__,
> -                  ICL_TYPE_POINTER, tdc,
> -                  ICL_TYPE_INT32, tdc->dflags);
> -       afs_osi_Wakeup(&tdc->validPos);
> +       if (afs_osi_Wakeup(&tdc->validPos) =3D=3D 0)
> +           afs_Trace4(afs_iclSetp, CM_TRACE_DCACHEWAKE,
> +                      ICL_TYPE_STRING, __FILE__,
> +                      ICL_TYPE_INT32, __LINE__,
> +                      ICL_TYPE_POINTER, tdc,
> +                      ICL_TYPE_INT32, tdc->dflags);
>         if (avc->execsOrWriters =3D=3D 0) tdc->f.states &=3D =
~DWriting;
>=20
>=20
> -- Nathan
>=20
> ------------------------------------------------------------
> Nathan Neulinger                       EMail:  nneul@umr.edu
> University of Missouri - Rolla         Phone: (573) 341-4841
> Computing Services                       Fax: (573) 341-4216
> _______________________________________________
> OpenAFS-devel mailing list
> OpenAFS-devel@openafs.org
> https://lists.openafs.org/mailman/listinfo/openafs-devel
>=20