[OpenAFS-devel] [PATCH] change OpenAFS-1.2.10 SRPM to work better with RedHat

Derrick J Brashear shadow@dementia.org
Fri, 15 Aug 2003 12:35:18 -0400 (EDT)


Don't CC me, I read openafs-devel.

On Fri, 15 Aug 2003, David Howells wrote:

>
> > On Fri, 15 Aug 2003, David Howells wrote:
> >
> > >   (1) The only kernel modules built are all appropriate to the currently
> > >       running kernel version and the target CPU specified on the command line.
> >
> > What's the impetus behind this change? Our binary releases for RedHat
> > Linux versions are done on a single machine at one time with all kernel
> > source versions installed.
>
> There are several reasons:
>
>  (1) I've had trouble with the script that is supposed to pick the name of the
>      module. It doesn't always cope with changes in the format of the name. It
>      can then pick the wrong module, muck around with it and force load it:-(

Which script? There's a runtime script, but I want to know about the above
change, which refers to what you're building. (You corrected yourself on
this, but it's still a build-time change)
>
>  (3) Modules from one version of the kernel shouldn't be changed on the fly to
>      fit another build of the kernel or a different configuration thereof.

They were never changed. No modification is made to built modules.

The script that loads them tries to guess which one can be used with this
kernel. If the __iget4 (I think) symbol is versioned the same in 2
kernels, it could lose, and that's a problem, but no patching is done.

>  (6) You don't have to rebuild everything for all kernels upon the advent of a
>      new kernel. You can just build a new set of modules for that kernel, and
>      nothing else... not even a new userspace.

No argument.

Let me ask a question more clearly: do your changes preclude building for
all kernels whose sources I have installed (even if I can't do it with a
single invocation of rpm, let's ignore than for the moment, can I at least
build for older kernerls?)