[OpenAFS-devel] [PATCH] useless labels
Joe Buehler
jbuehler@hekimian.com
Thu, 13 Nov 2003 11:17:05 -0500
I changed them all to comments because some of them look like they
have documentation value.
+ cvs diff -u ./src/WINNT/afsd/smb.c
Index: ./src/WINNT/afsd/smb.c
===================================================================
RCS file: /cvs/openafs/src/WINNT/afsd/smb.c,v
retrieving revision 1.12
diff -u -r1.12 smb.c
--- ./src/WINNT/afsd/smb.c 25 Aug 2003 18:24:22 -0000 1.12
+++ ./src/WINNT/afsd/smb.c 13 Nov 2003 16:15:32 -0000
@@ -6156,7 +6156,7 @@
}
#endif /* !DJGPP */
- try_addname:
+ /* try_addname */
/* and declare our name so we can receive connections */
memset(ncbp, 0, sizeof(*ncbp));
len=lstrlen(smb_localNamep);
+ cvs diff -u ./src/libadmin/pts/afs_ptsAdmin.c
Index: ./src/libadmin/pts/afs_ptsAdmin.c
===================================================================
RCS file: /cvs/openafs/src/libadmin/pts/afs_ptsAdmin.c,v
retrieving revision 1.8
diff -u -r1.8 afs_ptsAdmin.c
--- ./src/libadmin/pts/afs_ptsAdmin.c 15 Jul 2003 23:15:31 -0000 1.8
+++ ./src/libadmin/pts/afs_ptsAdmin.c 13 Nov 2003 16:15:33 -0000
@@ -2257,7 +2257,7 @@
}
rc = 1;
- fail_SetUserAccess:
+ /* fail_SetUserAccess */
if (st != NULL) {
*st = tst;
+ cvs diff -u ./src/viced/afsfileprocs.c
Index: ./src/viced/afsfileprocs.c
===================================================================
RCS file: /cvs/openafs/src/viced/afsfileprocs.c,v
retrieving revision 1.72
diff -u -r1.72 afsfileprocs.c
--- ./src/viced/afsfileprocs.c 8 Aug 2003 20:40:42 -0000 1.72
+++ ./src/viced/afsfileprocs.c 13 Nov 2003 16:15:35 -0000
@@ -5896,7 +5896,7 @@
FS_UNLOCK;
}
#endif /* FS_STATS_DETAILED */
- out:
+ /* out */
return errorCode;
} /*common_GiveUpCallBacks */
+ cvs diff -u ./src/bozo/bosoprocs.c
Index: ./src/bozo/bosoprocs.c
===================================================================
RCS file: /cvs/openafs/src/bozo/bosoprocs.c,v
retrieving revision 1.17
diff -u -r1.17 bosoprocs.c
--- ./src/bozo/bosoprocs.c 24 Oct 2003 06:31:49 -0000 1.17
+++ ./src/bozo/bosoprocs.c 13 Nov 2003 16:15:37 -0000
@@ -774,7 +774,7 @@
*tp = 0; /* in case getnthuser doesn't null-terminate the string */
code = afsconf_GetNthUser(bozo_confdir, an, tp, 256);
- fail:
+ /* fail */
osi_auditU(acall, BOS_ListSUserEvent, code, AUD_END);
return code;
}
+ cvs diff -u ./src/butc/dump.c
Index: ./src/butc/dump.c
===================================================================
RCS file: /cvs/openafs/src/butc/dump.c,v
retrieving revision 1.14
diff -u -r1.14 dump.c
--- ./src/butc/dump.c 8 Aug 2003 21:54:36 -0000 1.14
+++ ./src/butc/dump.c 13 Nov 2003 16:15:38 -0000
@@ -1877,7 +1877,7 @@
strcpy(vhptr->dumpSetName, nodePtr->dumpSetName);
strcpy(vhptr->preamble, "H++NAME#");
strcpy(vhptr->postamble, "T--NAME#");
- error_exit:
+ /* error_exit */
return (code);
}
+ cvs diff -u ./src/bucoord/ubik_db_if.c
Index: ./src/bucoord/ubik_db_if.c
===================================================================
RCS file: /cvs/openafs/src/bucoord/ubik_db_if.c,v
retrieving revision 1.8
diff -u -r1.8 ubik_db_if.c
--- ./src/bucoord/ubik_db_if.c 15 Jul 2003 23:14:47 -0000 1.8
+++ ./src/bucoord/ubik_db_if.c 13 Nov 2003 16:15:39 -0000
@@ -1357,7 +1357,7 @@
return (code);
}
- abort:
+ /* abort */
return (0);
}
+ cvs diff -u ./src/volser/vsprocs.c
Index: ./src/volser/vsprocs.c
===================================================================
RCS file: /cvs/openafs/src/volser/vsprocs.c,v
retrieving revision 1.24
diff -u -r1.24 vsprocs.c
--- ./src/volser/vsprocs.c 15 Jul 2003 23:17:49 -0000 1.24
+++ ./src/volser/vsprocs.c 13 Nov 2003 16:15:43 -0000
@@ -4413,7 +4413,7 @@
}
free(partEnts.partEntries_val);
}
- out:
+ /* out */
if (code)
fprintf(STDERR,
"Could not fetch the list of partitions from the server\n");
+ cvs diff -u ./src/butm/test_ftm.c
Index: ./src/butm/test_ftm.c
===================================================================
RCS file: /cvs/openafs/src/butm/test_ftm.c,v
retrieving revision 1.8
diff -u -r1.8 test_ftm.c
--- ./src/butm/test_ftm.c 15 Jul 2003 23:14:50 -0000 1.8
+++ ./src/butm/test_ftm.c 13 Nov 2003 16:15:44 -0000
@@ -414,7 +414,7 @@
if ((info.status & BUTM_STATUS_EOD) == 0) {
code = butm_ReadFileBegin(&info);
if (code && (code != BUTM_EOD)) {
- should_eot:
+ /* should_eot */
com_err(whoami, code, "Should have encountered an 'End Of Tape'");
ERROR_EXIT(8);
}
+ cvs diff -u ./src/budb/procs.c
Index: ./src/budb/procs.c
===================================================================
RCS file: /cvs/openafs/src/budb/procs.c,v
retrieving revision 1.11
diff -u -r1.11 procs.c
--- ./src/budb/procs.c 15 Jul 2003 23:14:48 -0000 1.11
+++ ./src/budb/procs.c 13 Nov 2003 16:15:46 -0000
@@ -165,7 +165,7 @@
if (afsconf_SuperUser(acdir, call, NULL))
permitted = 1;
- exit:
+ /* exit */
if (acdir)
afsconf_Close(acdir);
return (permitted);
@@ -2693,7 +2693,7 @@
if (eval)
ABORT(eval);
- error_exit:
+ /* error_exit */
FreeReturnList(&list);
code = ubik_EndTrans(ut);
return code;
@@ -3371,7 +3371,7 @@
if (eval)
ABORT(eval);
- error_exit:
+ /* error_exit */
FreeReturnList(&vollist);
code = ubik_EndTrans(ut);
return code;
+ cvs diff -u ./src/budb/db_text.c
Index: ./src/budb/db_text.c
===================================================================
RCS file: /cvs/openafs/src/budb/db_text.c,v
retrieving revision 1.9
diff -u -r1.9 db_text.c
--- ./src/budb/db_text.c 15 Jul 2003 23:14:48 -0000 1.9
+++ ./src/budb/db_text.c 13 Nov 2003 16:15:46 -0000
@@ -195,7 +195,7 @@
*nextOffset = -1;
}
- error_exit:
+ /* error_exit */
code = ubik_EndTrans(ut);
/* printf("in error exit, code=%ld\n", code); */
return (code);
@@ -480,7 +480,7 @@
if (code)
ABORT(code);
- error_exit:
+ /* error_exit */
code = ubik_EndTrans(ut);
return (code);
@@ -544,7 +544,7 @@
retval = open(mktemp(st), O_RDWR | O_CREAT | O_EXCL, 0600);
#endif
- error_exit:
+ /* error_exit */
return (retval);
}
#endif
+ cvs diff -u ./src/ptserver/pts.c
Index: ./src/ptserver/pts.c
===================================================================
RCS file: /cvs/openafs/src/ptserver/pts.c,v
retrieving revision 1.10
diff -u -r1.10 pts.c
--- ./src/ptserver/pts.c 15 Jul 2003 23:16:02 -0000 1.10
+++ ./src/ptserver/pts.c 13 Nov 2003 16:15:47 -0000
@@ -718,7 +718,7 @@
printf(".\n");
}
- done:
+ /* done */
if (lnames.namelist_val)
free(lnames.namelist_val);
if (lids.idlist_val)
--
Joe Buehler