[OpenAFS-devel] [PATCH] uninitialized variables

[Joe Buehler]

Please review these carefully, in case I made a semantic mistake.

+ cvs diff -u ./src/WINNT/afsd/afsd.c
Index: ./src/WINNT/afsd/afsd.c
===================================================================
RCS file: /cvs/openafs/src/WINNT/afsd/afsd.c,v
retrieving revision 1.4
diff -u -r1.4 afsd.c
--- ./src/WINNT/afsd/afsd.c	25 Aug 2003 18:24:22 -0000	1.4
+++ ./src/WINNT/afsd/afsd.c	13 Nov 2003 16:27:15 -0000
@@ -111,7 +111,6 @@
  	HWND hWnd;
  	HDC hDC;
  	TEXTMETRIC textmetric;
-	RECT rect;
  	INT nLineHeight;
          long code;
  	char *reason;
@@ -148,7 +147,7 @@
  	main_rect.right  = GetDeviceCaps(hDC, HORZRES);
  	main_rect.top    = GetDeviceCaps(hDC, LOGPIXELSY) / 4;   /* 1/4 inch */
  	ReleaseDC(hWnd, hDC);
-	main_rect.bottom = rect.top + nLineHeight;
+	main_rect.bottom = main_rect.top + nLineHeight;

  	osi_InitPanic(afsd_notifier);

+ cvs diff -u ./src/butc/lwps.c
Index: ./src/butc/lwps.c
===================================================================
RCS file: /cvs/openafs/src/butc/lwps.c,v
retrieving revision 1.9
diff -u -r1.9 lwps.c
--- ./src/butc/lwps.c	8 Aug 2003 20:01:25 -0000	1.9
+++ ./src/butc/lwps.c	13 Nov 2003 16:27:16 -0000
@@ -741,8 +741,7 @@
  		com_err(whoami, errno,
  			"Error waiting for callout script to terminate.");
  		TLog(taskId,
-		     "Can't get exit status from callout script. will prompt\n",
-		     wcode);
+		     "Can't get exit status from callout script. will prompt\n");
  		CallOut = 0;
  		break;
  	    }
+ cvs diff -u ./src/bucoord/commands.c
Index: ./src/bucoord/commands.c
===================================================================
RCS file: /cvs/openafs/src/bucoord/commands.c,v
retrieving revision 1.10
diff -u -r1.10 commands.c
--- ./src/bucoord/commands.c	15 Jul 2003 23:14:47 -0000	1.10
+++ ./src/bucoord/commands.c	13 Nov 2003 16:27:17 -0000
@@ -3097,7 +3097,6 @@
      afs_int32 code = 0;
      afs_int32 nextindex, index = 0;
      afs_int32 dbTime;
-    afs_int32 tapedumpid;
      budb_dumpList dl;
      struct budb_dumpEntry *dumpPtr;
      int i;
@@ -3136,7 +3135,7 @@
  		printf("%10u %10u %-2d %16s %2d %5d %s", dumpPtr->id,
  		       dumpPtr->parent, dumpPtr->level, ds,
  		       dumpPtr->tapes.maxTapes - dumpPtr->tapes.b + 1,
-		       dumpPtr->nVolumes, dumpPtr->name, tapedumpid);
+		       dumpPtr->nVolumes, dumpPtr->name);
  	    if (dumpPtr->initialDumpID)	/* an appended dump */
  		printf(" (%u)", dumpPtr->initialDumpID);
  	    else if (dumpPtr->appendedDumpID)	/* has appended dumps */
+ cvs diff -u ./src/volser/dumpstuff.c
Index: ./src/volser/dumpstuff.c
===================================================================
RCS file: /cvs/openafs/src/volser/dumpstuff.c,v
retrieving revision 1.23
diff -u -r1.23 dumpstuff.c
--- ./src/volser/dumpstuff.c	26 Aug 2003 02:59:20 -0000	1.23
+++ ./src/volser/dumpstuff.c	13 Nov 2003 16:27:18 -0000
@@ -919,7 +919,7 @@
  		    if (vnode->type != vNull && VNDISK_GET_INO(vnode)) {
  			cnt1++;
  			if (DoLogging) {
-			    afs_fsize_t vnodeLength;
+			    afs_fsize_t vnodeLength = 0; /* FIXME: currently useless */
  			    Log("RestoreVolume %u Cleanup: Removing old vnode=%u inode=%llu size=%llu\n", V_id(vp), bitNumberToVnodeNumber(i, class), (afs_uintmax_t) VNDISK_GET_INO(vnode), (afs_uintmax_t) vnodeLength);
  			}
  			IH_DEC(V_linkHandle(vp), VNDISK_GET_INO(vnode),
+ cvs diff -u ./src/budb/procs.c
Index: ./src/budb/procs.c
===================================================================
RCS file: /cvs/openafs/src/budb/procs.c,v
retrieving revision 1.11
diff -u -r1.11 procs.c
--- ./src/budb/procs.c	15 Jul 2003 23:14:48 -0000	1.11
+++ ./src/budb/procs.c	13 Nov 2003 16:27:19 -0000
@@ -3655,7 +3655,7 @@
      char *path = 0;
      dbadr dbAddr;
      int type, old, length, hash;
-    int block, index;
+    int block = 0, index = 0; /* FIXME: currently useless? */
      struct memoryHashTable *mht;
      afs_int32 eval, code = 0;

@@ -3807,7 +3807,7 @@
  {
      struct volFragment hostVolFragment, diskVolFragment;
      afs_int32 code;
-    int block, index;
+    int block = 0, index = 0; /* FIXME: currently useless? */

      while (dbAddr) {
  	code =

-- 
Joe Buehler