[OpenAFS-devel] rx peer hashing sucks.
Derrick J Brashear
shadow@dementia.org
Sun, 19 Sep 2004 22:42:17 -0400 (EDT)
I was debugging an error we had in 2 fileservers over 5 days (having never
seen the error before) and started delving into the rx_peerHashTable.
There are a lot of unused buckets. One bucket (155) has a huge number of
entries. It's a little-endian host. Most of the clients are in the same
class B network block. The hash is:
#define PEER_HASH(host, port) ((host ^ port) & rx_hashTableMask)
Can you see where I'm going with this?
So in theory we want to hash quickly, so is using a bitshift in the peer
hash for little-endian only reasonable?