[OpenAFS-devel] gcc 4.0, Fedora Core 4 patch

[Adam Goode]

--=-5mRVvBdvlfgHD5/SiLRP
Content-Type: multipart/mixed; boundary="=-0GwPy4El12LNlsNy1I7F"


--=-0GwPy4El12LNlsNy1I7F
Content-Type: text/plain
Content-Transfer-Encoding: quoted-printable

On Fri, 2005-06-17 at 03:16 -0400, Jeffrey Hutzelman wrote:
>=20
> On Thursday, June 16, 2005 10:43:22 AM -0400 Adam Goode=20
> <agoode@andrew.cmu.edu> wrote:
>=20
> > Here is a tiny patch to get OpenAFS working on Fedora Core 4. FC4 build=
s
> > everything, including the kernel, with GCC 4.0. Without this patch,
> > compilation of the kernel modules dies with "struct coda_inode_info
> > redefined" and "struct xfs_inode_info redefined".
> >
> > This patch just removes these definitions from src/afs/sysincludes.h. I
> > don't know if this is correct in all cases, but it does work here. Also=
,
> > do the nearby #define statements need to go? I'm not sure.
>=20
>=20
> Just ripping out code because it doesn't work on your machine is not real=
ly=20
> a fix; it's just a hack.  Better to fix the underlying problem, if there =
is=20
> one, or deal with the portability issues.
>=20
> The right fix is to move the #endif so that struct coda_inode_info is=20
> defined here only if _LINUX_CODA_FS_I was not already defined, and to put=
=20
> an equivalent conditional around the definitions of _LINUX_XFS_FS_I and=20
> struct xfs_inode_info.  This should happen in both src/afs/sysinclude.h a=
nd=20
> in src/rx/rx_kcommon.h
>=20


Thank you for your assistance! Here is a revised patch which hopefully
works better for everyone. Please let me know if you have any more
comments.


Thanks,

Adam


--=-0GwPy4El12LNlsNy1I7F
Content-Disposition: attachment; filename=openafs-1.3.84-gcc4-fc4-v2.patch
Content-Transfer-Encoding: base64
Content-Type: text/x-patch; name=openafs-1.3.84-gcc4-fc4-v2.patch; charset=UTF-8

ZGlmZiAtdXIgb3BlbmFmcy0xLjMuODQvc3JjL2Fmcy9zeXNpbmNsdWRlcy5oIG9wZW5hZnMtMS4z
Ljg0LWFnb29kZS9zcmMvYWZzL3N5c2luY2x1ZGVzLmgNCi0tLSBvcGVuYWZzLTEuMy44NC9zcmMv
YWZzL3N5c2luY2x1ZGVzLmgJMjAwNS0wNC0wMyAxNDoxODo1NC4wMDAwMDAwMDAgLTA0MDANCisr
KyBvcGVuYWZzLTEuMy44NC1hZ29vZGUvc3JjL2Fmcy9zeXNpbmNsdWRlcy5oCTIwMDUtMDYtMTcg
MTA6MDI6MzYuMDAwMDAwMDAwIC0wNDAwDQpAQCAtNzQsMTMgKzc0LDE1IEBADQogICovDQogI2lm
bmRlZiBfTElOVVhfQ09EQV9GU19JDQogI2RlZmluZSBfTElOVVhfQ09EQV9GU19JDQotI2VuZGlm
DQogI2RlZmluZSBfQ0ZTX0hFQURFUl8NCiBzdHJ1Y3QgY29kYV9pbm9kZV9pbmZvIHsNCiB9Ow0K
KyNlbmRpZg0KKyNpZm5kZWYgX0xJTlVYX1hGU19GU19JDQogI2RlZmluZSBfTElOVVhfWEZTX0ZT
X0kNCiBzdHJ1Y3QgeGZzX2lub2RlX2luZm8gew0KIH07DQorI2VuZGlmDQogI2luY2x1ZGUgPGFz
bS91YWNjZXNzLmg+DQogI2luY2x1ZGUgPGxpbnV4L2xpc3QuaD4NCiAjaW5jbHVkZSA8bGludXgv
ZGNhY2hlLmg+DQpkaWZmIC11ciBvcGVuYWZzLTEuMy44NC9zcmMvcngvcnhfa2NvbW1vbi5oIG9w
ZW5hZnMtMS4zLjg0LWFnb29kZS9zcmMvcngvcnhfa2NvbW1vbi5oDQotLS0gb3BlbmFmcy0xLjMu
ODQvc3JjL3J4L3J4X2tjb21tb24uaAkyMDA0LTEyLTE3IDEwOjM0OjA1LjAwMDAwMDAwMCAtMDUw
MA0KKysrIG9wZW5hZnMtMS4zLjg0LWFnb29kZS9zcmMvcngvcnhfa2NvbW1vbi5oCTIwMDUtMDYt
MTcgMTA6MDM6MjQuMDAwMDAwMDAwIC0wNDAwDQpAQCAtMjEsMTEgKzIxLDExIEBADQogI2lmZGVm
IEFGU19MSU5VWDIyX0VOVg0KICNpZm5kZWYgX0xJTlVYX0NPREFfRlNfSQ0KICNkZWZpbmUgX0xJ
TlVYX0NPREFfRlNfSSAxDQotI2VuZGlmDQogI2RlZmluZSBfQ09EQV9IRUFERVJfIDENCiBzdHJ1
Y3QgY29kYV9pbm9kZV9pbmZvIHsNCiB9Ow0KICNlbmRpZg0KKyNlbmRpZg0KICNpZmRlZiBBRlNf
REFSV0lOX0VOVg0KICNpZm5kZWYgX01BQ0hfRVRBUF9IXw0KICNkZWZpbmUgX01BQ0hfRVRBUF9I
Xw0K


--=-0GwPy4El12LNlsNy1I7F--

--=-5mRVvBdvlfgHD5/SiLRP
Content-Type: application/pgp-signature; name=signature.asc
Content-Description: This is a digitally signed message part

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.1 (GNU/Linux)

iD8DBQBCst4AlenB4PQRJawRAiUGAJ9haQ5KdVMUGdD8HJtXUcAdgFOQ/wCgsTao
CuefsSZMdNoMSiis77+gq5c=
=afQX
-----END PGP SIGNATURE-----

--=-5mRVvBdvlfgHD5/SiLRP--