[OpenAFS-devel] Salvager should be less verbose (with patch)
Jeffrey Hutzelman
jhutz@cmu.edu
Fri, 18 Mar 2005 17:23:31 -0500
On Friday, March 18, 2005 11:37:43 AM -0500 Chaskiel M Grundman
<cg2v@andrew.cmu.edu> wrote:
> --On Friday, March 18, 2005 10:04:52 AM -0500 Derrick J Brashear
> <shadow@dementia.org> wrote:
>
>> The question is how verbose (if at all) we want to keep it. Some
>> verbosity is not necessarily a bad thing.
> This particular bit of verbosity isn't very interesting. it's not a
> progress indicator for a slow operation (or at least, it shouldn't be in
> any normal case), and the only information it really adds is the total
> number of inodes in the volume group, which I don't see as being
> interesting. Salvagelogs are hard enough to read as it is without adding
> more stuff that has little semantic value.
I agree. It was debugging code, and served its purpose.
Rip it out.