[OpenAFS-devel] [PATCH 1/2] linux < 2.4 cleanup

[Tom Keiser]

On 5/7/05, chas williams - CONTRACTOR <chas@cmf.nrl.navy.mil> wrote:
> In message <1115417151.4125.11.camel@jack.dev.in.athenacr.com>,Andres Sal=
omon w
> rites:
> >a) convert to using gcc-style architecture identifiers for linux (ie
> >__ia64__ instead of AFS_IA64_LINUX20_ENV)
>=20
> i would prefer this not to happen if i have a choice.  mostly for
> consistency reasons.

I agree.  We should try to keep the macros consistent.  Furthermore,
__ia64__ and AFS_IA64_LINUX20_ENV have somewhat different meanings.=20
One means (gcc && ia64), while the other means (linux && ia64).  I
suppose you could safely use that macro in the linux osdep
directories, but I don't like the inconsistency that creates.

Furthermore, the AFS_IA64_LINUX20_ENV macro would have to remain
because we can't use __ia64__ outside of the osdep code.  We already
support HP-UX on IA64, and we may support other OS's on ia64 in the
future.  Even if __ia64__ isn't ambiguous to the compiler (os uses a
different compiler), it's use certainly would be confusing to
developers.  Besides, relegating gcc-isms (and other compiler's
idiolects as well) as far to the corner as possible seems like the
right way to go ;)


Regards,

--=20
Tom Keiser
tkeiser@gmail.com