[OpenAFS-devel] [PATCH 1/2] linux < 2.4 cleanup

[Andres Salomon]

On Sat, 2005-05-07 at 15:46 -0400, Tom Keiser wrote:
> On 5/7/05, chas williams - CONTRACTOR <chas@cmf.nrl.navy.mil> wrote:
> > In message <1115417151.4125.11.camel@jack.dev.in.athenacr.com>,Andres Salomon w
> > rites:
> > >a) convert to using gcc-style architecture identifiers for linux (ie
> > >__ia64__ instead of AFS_IA64_LINUX20_ENV)
> > 
> > i would prefer this not to happen if i have a choice.  mostly for
> > consistency reasons.
> 
> I agree.  We should try to keep the macros consistent.  Furthermore,
> __ia64__ and AFS_IA64_LINUX20_ENV have somewhat different meanings. 
> One means (gcc && ia64), while the other means (linux && ia64).  I

gcc, or something that emulates gcc, is a requirement for compiling the
Linux kernel.  I don't think there's any problem with including it in
the kernelspace portion of the openafs driver.  My patch was only going
to touched the LINUX specific directories, as it does mean (linux &&
ia64).


> suppose you could safely use that macro in the linux osdep
> directories, but I don't like the inconsistency that creates.
> 

Well, the goal for userspace is to get rid of the linux-specific macros,
but in a cleaner way.  Perhaps putting all the linux-specific stuff in a
separate file or directory, and having functions call out it it; maybe
some other way.  For right now, I'm more concerned about kernelspace
code.