[OpenAFS-devel] [PATCH 1/2] linux < 2.4 cleanup
Derrick J Brashear
shadow@dementia.org
Sun, 8 May 2005 00:41:26 -0400 (EDT)
On Sat, 7 May 2005, Andres Salomon wrote:
>> I agree. We should try to keep the macros consistent. Furthermore,
>> __ia64__ and AFS_IA64_LINUX20_ENV have somewhat different meanings.
>> One means (gcc && ia64), while the other means (linux && ia64). I
>
> gcc, or something that emulates gcc, is a requirement for compiling the
> Linux kernel. I don't think there's any problem with including it in
> the kernelspace portion of the openafs driver. My patch was only going
> to touched the LINUX specific directories, as it does mean (linux &&
> ia64).
That's still sort of crappy. Why not keep what we have, but look for ways
to continue to move to ifdefs by function/action/feature instead of
hardcoded by system?